Create English locale #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakrilov
reviewed
Nov 29, 2024
vakrilov
reviewed
Nov 29, 2024
|
Awesome job! 🎉 Code looks good!
I will take some time to test on IOS. Also, If there are any additional steps related to to generating translation files, can you please note them in the README.md |
vakrilov
reviewed
Nov 29, 2024
vakrilov
reviewed
Nov 29, 2024
vakrilov
reviewed
Nov 29, 2024
vakrilov
reviewed
Nov 29, 2024
vakrilov
reviewed
Nov 29, 2024
There was a problem hiding this comment.
Tested on IOS and all looks good except the default language select
|
Great job, @ivonasto and good catch with the rating dialog 🤦 |
change "main" to "official" Co-authored-by: Alexander Vakrilov <[email protected]>
change "main" to "official" Co-authored-by: Alexander Vakrilov <[email protected]>
add indent Co-authored-by: Alexander Vakrilov <[email protected]>
add indent Co-authored-by: Alexander Vakrilov <[email protected]>
Co-authored-by: Alexander Vakrilov <[email protected]>
- extract language code from platform locale string before checking for support
ivonasto
had a problem deploying
to
development
GitHub Actions
Failure
ivonasto
had a problem deploying
to
development
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translation of the app in English, excluding data coming from the server. I suggest we split the task in two.
The app checks if the platform's language is supported, if not, it defaults to English. There is a button on the Settings page to change it manually. Its design is rudimentary, suggestions are welcome.
Fixed a small mistake in the
app_rating_manager.dart- the labels on thenoandmaybe letterbuttons were interchanged.I have doubts about the following translation: "същински трасета". I went with "main routes" could also be "official routes"?
I tested it on Android only again.