Env util helper get_path
#73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against f6c24ab |
antonagestam
approved these changes
Nov 5, 2021
There was a problem hiding this comment.
Nice! See related plans to improve the environment getters: #47
antonagestam
suggested changes
Nov 5, 2021
|
I just recalled that this is the only thing we have type tests for, which is nice to have because it verifies that the exposed typing is correct. Would you mind adding a case for Path as well? https://github.com/5monkeys/django-bananas/blob/master/tests/test_env.yaml |
|
We want to test that:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a suggestion from @flaeppe, this adds a method to the environment parsing helper that allows parsing strings as a
pathlib.Path.