-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hints to admin and query modules #76
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against 8ea16bf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, are we ready to add py.typed
(might need a manifest entry)?
Yeah, I think we are. Sounds correct that we need a manifest entry for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
Continuation of #70
There's probably quite a bit of refinement that can be done here, but at least it should make tests green without ignoring errors from
query
andadmin
modules.