-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce reusable workflows #79
Conversation
- Workflow for building and publishing package to PyPI when Github release is created. - Reusable workflow for running pre-commit, because the action is deprecated. - Update supported versions in README.
Minimum allowed coverage is Generated by 🐒 cobertura-action against 08f5d88 |
Maybe we can add in a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, should we clear out old pypi release targets in the Makefile
?
@flaeppe Good ideas 👍 I introduced a new workflow that runs I'll await more opinions here, as this adds all these dependencies on the less-action/reusables repository. I hope it'll feel transparent enough to use. It'd be very easy to migrate away from that by either forking the project, or simply copying the workflows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
From discussion here: #78 (comment)
This requires generating an access token on PyPI scoped for django-bananas and creating the secret
PYPI_API_TOKEN
with that value.