Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce reusable workflows #79

Merged
merged 4 commits into from
Mar 3, 2022
Merged

Conversation

antonagestam
Copy link
Contributor

  • Workflow for building and publishing package to PyPI when Github release is created.
  • Reusable workflow for running pre-commit, because the action is deprecated.
  • Update supported versions in README.

From discussion here: #78 (comment)

This requires generating an access token on PyPI scoped for django-bananas and creating the secret PYPI_API_TOKEN with that value.

- Workflow for building and publishing package to PyPI when Github
  release is created.
- Reusable workflow for running pre-commit, because the action is
  deprecated.
- Update supported versions in README.
@github-actions
Copy link

github-actions bot commented Feb 14, 2022

File Coverage Lines Branches Missing
All files 94% 97% 91%
bananas/__init__.py 79% 83% 75% 19-20
bananas/models.py 98% 100% 96%
bananas/url.py 97% 100% 95%
bananas/admin/extension.py 94% 100% 88%
bananas/admin/api/i18n.py 91% 83% 100% 11
bananas/admin/api/mixins.py 72% 77% 67% 87 95-101 112 128 138-149
bananas/admin/api/serializers.py 91% 100% 83%
bananas/admin/api/versioning.py 93% 100% 87%
bananas/admin/api/views.py 99% 98% 100% 137
bananas/admin/api/schemas/base.py 91% 83% 100% 11
bananas/admin/api/schemas/yasg.py 90% 95% 86% 92 101 140-141
bananas/drf/fencing.py 91% 94% 87% 91-97 136
bananas/management/commands/syncpermissions.py 89% 95% 83% 32

Minimum allowed coverage is 85%

Generated by 🐒 cobertura-action against 08f5d88

@flaeppe
Copy link
Contributor

flaeppe commented Feb 14, 2022

Maybe we can add in a python3 -m build --sdist --wheel . together with a twine check --strict . as a separate CI-job? Hopefully ensuring that we don't merge stuff that'll make the release workflow fail.

Copy link
Contributor

@flaeppe flaeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, should we clear out old pypi release targets in the Makefile?

@antonagestam
Copy link
Contributor Author

@flaeppe Good ideas 👍 I introduced a new workflow that runs twine check --strict dist/*.

I'll await more opinions here, as this adds all these dependencies on the less-action/reusables repository. I hope it'll feel transparent enough to use. It'd be very easy to migrate away from that by either forking the project, or simply copying the workflows.

Copy link
Contributor

@flaeppe flaeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@antonagestam antonagestam merged commit aff68e2 into master Mar 3, 2022
@antonagestam antonagestam deleted the feature/reusable-workflows branch March 3, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants