Type check project the tests are running on

[flaeppe]

I split the content under tests/ in 2 to only allow tests([mypy-tests.tests.*]) to be excluded from type checking.

I considered type checking test cases too, but browsing quickly through the ~150 errors spewed out they're mainly hitting the disallow_untyped_defs-errors. So splitting it up like this felt like a reasonable compromise that'll capture meaningful errors from type usage.

Let me know what you think.

[github-actions]

File	Coverage	Lines	Branches		Missing
All files	94%	96%	91%	✅
bananas/__init__.py	79%	83%	75%	❌	19-20
bananas/environment.py	98%	97%	100%	✅	223 229 232
bananas/models.py	98%	100%	96%	✅
bananas/url.py	97%	100%	95%	✅
bananas/admin/extension.py	94%	100%	88%	✅
bananas/admin/api/i18n.py	91%	83%	100%	✅	11
bananas/admin/api/mixins.py	72%	77%	67%	❌	87 95-101 112 128 138-149
bananas/admin/api/serializers.py	91%	100%	83%	✅
bananas/admin/api/versioning.py	93%	100%	87%	✅
bananas/admin/api/views.py	99%	98%	100%	✅	137
bananas/admin/api/schemas/base.py	91%	83%	100%	✅	11
bananas/admin/api/schemas/yasg.py	90%	95%	86%	✅	92 101 140-141
bananas/drf/fencing.py	91%	94%	87%	✅	91-97 136
bananas/management/commands/syncpermissions.py	89%	95%	83%	✅	32

Minimum allowed coverage is 85%

Generated by 🐒 cobertura-action against 2295f72

[antonagestam]

@flaeppe

browsing quickly through the ~150 errors spewed out they're mainly hitting the disallow_untyped_defs-errors

We could always disable disallow_untyped_defs in tests? :)

[flaeppe]

@flaeppe

browsing quickly through the ~150 errors spewed out they're mainly hitting the disallow_untyped_defs-errors

We could always disable disallow_untyped_defs in tests? :)

Yeah, true. I did that and fixed some errors that popped up

[flaeppe]

Could perhaps be nice to move to pytest as that might align better with mypy behaviour on native asserts:

django-bananas/tests/tests/drf/test_fencing.py

Lines 186 to 187 in 2295f72

	assert isinstance(exc_info.exception.detail, ErrorDetail)
	self.assertEqual(exc_info.exception.detail.code, "missing_header")

[antonagestam]

@flaeppe Yeah would be nice to introduce pytest, a little surprising though that unittest's assertIsInstance doesn't use TypeGuard in typeshed yet.

[flaeppe]

@antonagestam indeed, that's a bit surprising