Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Django 4.2 #88

Merged
merged 4 commits into from
Apr 4, 2023
Merged

Support Django 4.2 #88

merged 4 commits into from
Apr 4, 2023

Conversation

oriolclosa
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

File Coverage Lines Branches Missing
All files 92% 96% 87%
bananas/__init__.py 79% 83% 75% 19-20
bananas/environment.py 98% 97% 100% 223 229 232
bananas/models.py 97% 100% 95%
bananas/url.py 96% 100% 93%
bananas/admin/extension.py 93% 100% 86%
bananas/admin/api/i18n.py 91% 83% 100% 11
bananas/admin/api/mixins.py 69% 75% 63% 86 94-102 113 129 139-150
bananas/admin/api/serializers.py 75% 100% 50%
bananas/admin/api/versioning.py 91% 100% 83%
bananas/admin/api/views.py 99% 98% 100% 137
bananas/admin/api/schemas/base.py 91% 83% 100% 11
bananas/admin/api/schemas/yasg.py 88% 95% 82% 92 101 140-141
bananas/drf/fencing.py 87% 94% 80% 91-97 136
bananas/management/commands/syncpermissions.py 87% 95% 80% 32

Minimum allowed coverage is 85%

Generated by 🐒 cobertura-action against b3e2c68

@oriolclosa oriolclosa requested a review from flaeppe April 4, 2023 12:39
tox.ini Outdated Show resolved Hide resolved
@oriolclosa oriolclosa merged commit c2bd412 into master Apr 4, 2023
@@ -25,13 +25,15 @@ install_command =
extras =
test
drf
deps = django22: Django>=2.2,<2.3
django32: Django<4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a mistake, the deps keyword was removed, and I don't think tests ran with correct dependencies. Interesting that tox ran at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants