Return property mapping on get #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+32
to
+33
|
|
||
| def test_getting_enum_property() -> None: |
There was a problem hiding this comment.
Suggested change
| def test_getting_enum_property() -> None: | |
| def test_getting_enum_property() -> None: |
I think black will complain here?
There was a problem hiding this comment.
Suggested change
| def test_getting_enum_property() -> None: | |
| def test_can_introspect_property_attributes() -> None: |
Let's name the test so that the aspect we're testing is clear.
|
Merging main should solve the CI issue (was lacking a pin of the Python version, fixed here: #7) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure if this is something you want to allow, but since it closes #4, until there's a better solution this is better than nothing.