Suggestion for PR template: HOW can this pull request be tested? -> HOW was this pull request tested?
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walro
approved these changes
Apr 26, 2024
gomoripeti
approved these changes
Apr 26, 2024
weistrand
approved these changes
Apr 29, 2024
kickster97
approved these changes
Apr 29, 2024
tbroden84
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
This communicates more clearly that changes should be tested.
WHAT is this pull request doing?
Changes the phrasing of the last question.
HOW was this pull request tested?
I used it in https://github.com/84codes/machines/pull/217