Replace github.actor with github.event.pull_request.user.login #565
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
github.actor
は細工をすることで詐称でき、auto mergeなどしている場合に悪意のあるコードをマージさせる脆弱性があることがわかりました。https://www.synacktiv.com/publications/github-actions-exploitation-dependabot
https://github.com/dependabot/fetch-metadata を使用している場合はこの影響を受けません。
このワークフロー内でのチェックにより詐称されている場合は落ちるためです。
そのため現状では影響を受けませんが、より安全な記述に置き換えることで攻撃を受ける可能性を減らします。
やったこと
github.actor
をgithub.event.pull_request.user.login
に置き換えました。READMEでもこの記述が使われています。