Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host terminfo as a fallback #1194

Merged
merged 2 commits into from
Feb 15, 2024
+1 −0
Merged

Add host terminfo as a fallback #1194

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
416b84c
Add host terminfo separately and add it as fallback
sandorex Feb 7, 2024
f06755c
Remove unecessary volume mount
sandorex Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Loading
Loading status checks…
Add host terminfo separately and add it as fallback 
This should allow the user to use a modern terminal without installing anything
additional inside the container itself
@sandorex
sandorex committed Feb 7, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 416b84cff0635de4adca62f3433466b8ecc59f14
2 changes: 2 additions & 0 deletions distrobox-create
View file
Original file line number Diff line number Diff line change
@@ -602,6 +602,8 @@ generate_command() {
--env \"SHELL=$(basename "${SHELL:-"/bin/bash"}")\"
--env \"HOME=${container_user_home}\"
--env \"container=${container_manager}\"
--env \"TERMINFO_DIRS=/usr/share/terminfo:/usr/share/terminfo-host\"
--volume /usr/share/terminfo:/usr/share/terminfo-host:ro
--volume /:/run/host:rslave
--volume /tmp:/tmp:rslave
--volume \"${distrobox_entrypoint_path}\":/usr/bin/entrypoint:ro