Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow custom feedback icons #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jeffuyeno
Copy link
Collaborator

So... we don't use bootstrap glyphicons... this seems like an edge case, but it does increase happiness.

  • add custom template parameter feedback-template
  • add valid-icon
  • add invalid-icon
  • add tests
  • add docs on usage

@jeffuyeno
Copy link
Collaborator Author

So... I was thinking about this.... no one is going to want to configure every single instance of form controls.... I'll need to add a configuration service so we can just set the icon types and the feedback template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant