Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build warnings and clippy warnings #328

Merged
merged 6 commits into from
Jul 10, 2024
Merged

Conversation

dhilipsiva
Copy link
Contributor

Pull Request

Fix Cargo Build Warning and Clippy Warnings

Checklist

  • I have tested the changes locally.
  • I have reviewed the code changes.

- Added `rust-toolchain.toml` file with `channel` set to `"1.79.0"`
- Added `rustfmt` and `clippy` components
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 65.78947% with 52 lines in your changes missing coverage. Please review.

Project coverage is 43.82%. Comparing base (c459b13) to head (324c3ba).

Files Patch % Lines
packages/transport_webrtc/src/transport/webrtc.rs 0.00% 14 Missing ⚠️
packages/media_connector/src/agent_service.rs 0.00% 6 Missing ⚠️
packages/media_connector/src/handler_service.rs 0.00% 6 Missing ⚠️
...rnal/local_track/packet_selector/video_h264_sim.rs 78.26% 5 Missing ⚠️
...ernal/local_track/packet_selector/video_vp9_svc.rs 86.48% 5 Missing ⚠️
packages/media_gateway/src/agent_service.rs 0.00% 5 Missing ⚠️
...ernal/local_track/packet_selector/video_vp8_sim.rs 90.69% 4 Missing ⚠️
...s/media_core/src/endpoint/internal/remote_track.rs 0.00% 2 Missing ⚠️
bin/src/http/api_console.rs 0.00% 1 Missing ⚠️
bin/src/server/connector.rs 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
- Coverage   43.89%   43.82%   -0.07%     
==========================================
  Files         117      117              
  Lines       12984    12982       -2     
==========================================
- Hits         5699     5690       -9     
- Misses       7285     7292       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@giangndm giangndm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for very carefully merge request, I have some comments and questions, let discuss more in details.

bin/src/server/media/runtime_worker.rs Show resolved Hide resolved
packages/audio_mixer/src/lib.rs Show resolved Hide resolved
packages/transport_webrtc/src/transport.rs Outdated Show resolved Hide resolved
@dhilipsiva
Copy link
Contributor Author

@giangndm Thank you for your response. I have addressed all your questions. Please let me know if you have more questions or feedbacks.

@dhilipsiva
Copy link
Contributor Author

@giangndm I have updated the code as per your feedbacks. Please let me know if I need to do more changes.

@dhilipsiva dhilipsiva requested a review from giangndm July 9, 2024 18:47
Copy link
Contributor

@giangndm giangndm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge it now. Thank you for great contribution.

@giangndm giangndm merged commit a6e1d51 into 8xFF:master Jul 10, 2024
9 of 10 checks passed
@dhilipsiva dhilipsiva deleted the fix-warnings branch July 10, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants