Concise messages: edit user interface messages to fix spelling and grammar issues, general conciseness #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than using '%s...', label the submenu items directly.
… for readability.
…, dedicated 'enabled/disabled' and friends removed. Rather than using messages of the form 'message %s' when toggling settings, just announce the actual toggle message directly to make them conform better with NVDA Core expectations. Various input help messages were edited to fix grammar issues and to make commands clearer.
…bined separate strings in various options, along with fixing spelling and grammar issues.
|
Thanks a lot! Looks good to me (I've just made a quick review). |
AAClause
reviewed
Jul 20, 2020
| if self.BRFMode: | ||
| speech.speakMessage(_("BRF mode enabled")) | ||
| else: | ||
| speech.speakMessage(_("BRF mode disabled")) | ||
| script_toggleBRFMode.__doc__ = _("Enable/disable BRF mode") |
There was a problem hiding this comment.
Suggested change
| script_toggleBRFMode.__doc__ = _("Enable/disable BRF mode") | |
| script_toggleBRFMode.__doc__ = _("Toggles BRF mode") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR fixes #75. Please review message edits in this PR and let me know if things are not clear or you wish to edit this further.
Thanks.