-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10 homework teacher feature be able to add links for other sources #14
Merged
Verdoner
merged 26 commits into
main
from
10-homework-teacher-feature-be-able-to-add-links-for-other-sources
Oct 23, 2024
Merged
10 homework teacher feature be able to add links for other sources #14
Verdoner
merged 26 commits into
main
from
10-homework-teacher-feature-be-able-to-add-links-for-other-sources
Oct 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble-to-add-links-for-other-sources' into 10-homework-teacher-feature-be-able-to-add-links-for-other-sources
JuliusJensen02
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, but codesniffer fails
…her-sources' of https://github.com/AAU-P5-Moodle/moodle-2 into 10-homework-teacher-feature-be-able-to-add-links-for-other-sources
JuliusJensen02
approved these changes
Oct 23, 2024
…work-teacher-feature-be-able-to-add-links-for-other-sources
Verdoner
deleted the
10-homework-teacher-feature-be-able-to-add-links-for-other-sources
branch
October 28, 2024 08:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request resolves issue #5, #9 & #10. There is also tests, which tests if the input on client side writes to the database & if the modal for making homework is created the right way.