Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate official and unofficial pipelines #334

Merged

Conversation

matteo-prosperi
Copy link

Separate official and unofficial pipelines.
This is to satisfy the requirement that pipelines marked as production never use the unofficial templates.

Copy link
Owner

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to need some changes to the in-house wiki for the template as well, which documents pipelines and their purposes.
And we'll probably want to send a notification within VS Core template users so they know to merge the latest template and adjust their pipelines manually.
Can you take care of all that in tandem with this, and let me know when you're ready for this to merge?

@matteo-prosperi
Copy link
Author

This is going to need some changes to the in-house wiki for the template as well, which documents pipelines and their purposes. And we'll probably want to send a notification within VS Core template users so they know to merge the latest template and adjust their pipelines manually. Can you take care of all that in tandem with this, and let me know when you're ready for this to merge?

I will first test these changes on the Gladstone repo. Then update the wiki, notify users and finally complete this PR. Thanks for confirming that these changes are reasonable, so I can go ahead with my testing :-)

@AArnott
Copy link
Owner

AArnott commented Jan 6, 2025

@matteo-prosperi You're going to need to set up git commit signing and rebase your commits for them to be merged. Repos exist that merge from this template that require commits to be signed, so this repo similarly requires this.

Copy link

@adrianvmsft adrianvmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the Expand script replace placeholders in both official.yml and unofficial.yml?

@matteo-prosperi matteo-prosperi force-pushed the dev/maprospe/unofficial_yml branch 2 times, most recently from af1d01b to 08a8240 Compare January 13, 2025 22:49
@matteo-prosperi matteo-prosperi force-pushed the dev/maprospe/unofficial_yml branch from 08a8240 to 82ed74f Compare January 13, 2025 22:53
@AArnott AArnott merged commit d158387 into AArnott:microbuild Jan 14, 2025
7 checks passed
@AArnott
Copy link
Owner

AArnott commented Jan 14, 2025

@matteo-prosperi I had to squash your PR because github wouldn't let me merge it. I don't know why. It gave an error about an invalid email address that I've never seen before. Your commit had this:

commit 82ed74f8a6d8392aaea9c66c3652642d72c0df4c (HEAD -> dev/maprospe/unofficial_yml)
Author: Matteo Prosperi <[email protected]>
Date:   Mon Jan 13 14:46:01 2025 -0800

That email address makes me wonder... how did you create this commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants