-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate official and unofficial pipelines #334
Separate official and unofficial pipelines #334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to need some changes to the in-house wiki for the template as well, which documents pipelines and their purposes.
And we'll probably want to send a notification within VS Core template users so they know to merge the latest template and adjust their pipelines manually.
Can you take care of all that in tandem with this, and let me know when you're ready for this to merge?
I will first test these changes on the Gladstone repo. Then update the wiki, notify users and finally complete this PR. Thanks for confirming that these changes are reasonable, so I can go ahead with my testing :-) |
@matteo-prosperi You're going to need to set up git commit signing and rebase your commits for them to be merged. Repos exist that merge from this template that require commits to be signed, so this repo similarly requires this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the Expand script replace placeholders in both official.yml and unofficial.yml?
af1d01b
to
08a8240
Compare
08a8240
to
82ed74f
Compare
@matteo-prosperi I had to squash your PR because github wouldn't let me merge it. I don't know why. It gave an error about an invalid email address that I've never seen before. Your commit had this:
That email address makes me wonder... how did you create this commit? |
Separate official and unofficial pipelines.
This is to satisfy the requirement that pipelines marked as production never use the unofficial templates.