feat: Add isManualUpdate flag to updateWidget #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To view this pull requests documentation preview, visit the following URL: docs.page/abausg/home_widget~315 Documentation is deployed and generated using docs.page. |
tenhobi
changed the title
ABausG
reviewed
Nov 19, 2024
| @@ -109,6 +109,7 @@ class HomeWidgetPlugin : | |||
| AppWidgetManager.getInstance(context.applicationContext) | |||
| .getAppWidgetIds(ComponentName(context, javaClass)) | |||
| intent.putExtra(AppWidgetManager.EXTRA_APPWIDGET_IDS, ids) | |||
| intent.putExtra("isManualUpdate", true) | |||
There was a problem hiding this comment.
I think manual is not really great wording here as it is not directly explaining everything
I would propose something like:
triggeredFromHomeWidget
Also it should use some constant defined on a HomeWidget scope so it can be reused also from a user's side without requiring a magic string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #314
Adds extra parameter so we can distinguish AppWidgetManager.EXTRA_APPWIDGET_IDS from system vs manual.
Checklist
exampleor documentation.Breaking Change?