Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addressing dropped sites with 0 birds #47

Draft
wants to merge 9 commits into
base: development
Choose a base branch
from

Conversation

see24
Copy link
Contributor

@see24 see24 commented Jan 31, 2024

Trying to address #46

@see24
Copy link
Contributor Author

see24 commented Jan 31, 2024

I also made some changes to the way the tests are structured. First of all I changed to a smaller ARU report to make the download faster. After downloading had been tested I changed the tests to use a global object for the downloaded report rather than redownloading inside each test_that. Downloading takes about 7s for me which quickly adds up so although it breaks the guideline of having each test_that be independent I think it is worth it because you will be more willing to re-run the tests more often.

@see24 see24 marked this pull request as ready for review January 31, 2024 16:31
Copy link

gitguardian bot commented Feb 27, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Username Password 298e5c0 tests/testthat/test-first.R View secret
- Username Password 4cb7543 tests/testthat/test-first.R View secret
- Username Password e101130 tests/testthat/test-first.R View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@agmacpha agmacpha marked this pull request as draft March 27, 2024 16:27
@agmacpha agmacpha requested a review from ecknight March 27, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant