-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addressing dropped sites with 0 birds #47
base: development
Are you sure you want to change the base?
Conversation
needed to keep other columns from none to avoid them being filtered out later
I also made some changes to the way the tests are structured. First of all I changed to a smaller ARU report to make the download faster. After downloading had been tested I changed the tests to use a global object for the downloaded report rather than redownloading inside each test_that. Downloading takes about 7s for me which quickly adds up so although it breaks the guideline of having each test_that be independent I think it is worth it because you will be more willing to re-run the tests more often. |
…downloading files everytime run offsets
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | Username Password | 298e5c0 | tests/testthat/test-first.R | View secret | |
- | Username Password | 4cb7543 | tests/testthat/test-first.R | View secret | |
- | Username Password | e101130 | tests/testthat/test-first.R | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Trying to address #46