Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

42 dev config #43

Draft
wants to merge 49 commits into
base: main
Choose a base branch
from
Draft

42 dev config #43

wants to merge 49 commits into from

Conversation

JhanSrbinovsky
Copy link
Collaborator

@JhanSrbinovsky JhanSrbinovsky commented Feb 12, 2025

see issue #42


🚀 The latest prerelease access-esm1p6/pr43-3 at 8f70ab1 is here: #43 (comment) 🚀

chrisb13 and others added 30 commits December 13, 2024 00:55
…l mom5 version and Dave Bi's cice code changes (now updated)
@JhanSrbinovsky JhanSrbinovsky linked an issue Feb 12, 2025 that may be closed by this pull request
Copy link

The model version in the spack.yaml has not been updated.
Either update it manually, or comment the following to have it updated and committed automatically:

  • !bump major for feature releases
  • !bump minor for bugfixes

@JhanSrbinovsky
Copy link
Collaborator Author

@blimlim arrggghhh - why is this failing? its just a straight up copy of SpinUp_b which has always worked, including today.

@blimlim
Copy link

blimlim commented Feb 12, 2025

Hi @JhanSrbinovsky!

The deployment system has different requirements depending on whether a pull request is marked as a draft or not, which I think is bringing up this error.

When a PR is not a draft, the deployment assumes that you're making a new release or new version of the model. In this case it requires the version number in

specs:
    - [email protected]_2024.12.0
...
projections:
          access-esm1p6: '{name}/dev_2024.12.0'

to be updated to something new.

For pull requests marked as drafts, this requirement doesn't apply and it will happily deploy prerelease executables without changes to the version number.

Is the goal to merge this PR into main? In this case, I'd try updating the version to dev_2025.02.0.

Otherwise if you're building some executables for testing, marking this PR as a draft should then let the build go ahead.

@JhanSrbinovsky JhanSrbinovsky marked this pull request as draft February 12, 2025 23:55
Copy link

The model version in the spack.yaml has not been updated.
Either update it manually, or comment the following to have it updated and committed automatically:

  • !bump major for feature releases
  • !bump minor for bugfixes

@blimlim
Copy link

blimlim commented Feb 13, 2025

!redeploy

Copy link

🚀 Deploying access-esm1.6 dev_2024.12.0 as prerelease pr43-1 with commit 087b6f2

Details and usage instructions

This access-esm1.6 model will be deployed as:

  • dev_2024.12.0 as a Release (when merged).
  • pr43-1 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-esm1p6/pr43-1

where the binaries shall be on your $PATH.
This Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-esm1p6-pr43-1 environment.

🛠️ Using: spack 0.22, spack-packages 2024.12.0, spack-config 2025.01.1

Details

It will be deployed using:

  • access-nri/spack on branch 0.22
  • access-nri/spack-packages version 2024.12.0
  • access-nri/spack-config version 2025.01.1

If this is not what was expected, commit changes to config/versions.json.

@JhanSrbinovsky JhanSrbinovsky self-assigned this Feb 13, 2025
@JhanSrbinovsky
Copy link
Collaborator Author

@blimlim - looks like the same error

@blimlim
Copy link

blimlim commented Feb 13, 2025

Hi @JhanSrbinovsky, I think the deployment itself was successful despite the messages from github! I've been able to load the modules listed:

module use /g/data/vk83/prerelease/modules
module load access-esm1p6/pr43-1

I think the Some checks were not successful message is just carrying over from earlier – @CodeGat is this correct?

@CodeGat
Copy link
Member

CodeGat commented Feb 13, 2025

Yeah. The failing check is from the initial deployment of the commit. The !redeployed commit succeeded.

The reason you're still seeing the red cross is because GitHub treats previous failed checks as a higher priority than new successes...bit of a quirk of GitHub!

@blimlim
Copy link

blimlim commented Feb 13, 2025

Thanks @CodeGat!

@JhanSrbinovsky
Copy link
Collaborator Author

Thanks for your help @blimlim & @CodeGat.

what did you to to get the redeploy to work @blimlim

@blimlim
Copy link

blimlim commented Feb 13, 2025

Redeploying is quite simple thanks to @CodeGat! You just have to add a comment saying "!redeploy"

@CodeGat
Copy link
Member

CodeGat commented Feb 13, 2025

Indeed. Its main use case was for redeploying changes to a git.BRANCH component, but since that isn't working at the moment the isn't as much reason to use it!

Copy link

🚀 Deploying access-esm1.6 dev_2024.12.0 as prerelease pr43-2 with commit 8f70ab1

Details and usage instructions

This access-esm1.6 model will be deployed as:

  • dev_2024.12.0 as a Release (when merged).
  • pr43-2 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-esm1p6/pr43-2

where the binaries shall be on your $PATH.
This Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-esm1p6-pr43-2 environment.

🛠️ Using: spack 0.22, spack-packages 2024.12.0, spack-config 2025.01.1

Details

It will be deployed using:

  • access-nri/spack on branch 0.22
  • access-nri/spack-packages version 2024.12.0
  • access-nri/spack-config version 2025.01.1

If this is not what was expected, commit changes to config/versions.json.

@JhanSrbinovsky
Copy link
Collaborator Author

!redeploy

Copy link

🚀 Deploying access-esm1.6 dev_2024.12.0 as prerelease pr43-3 with commit 8f70ab1

Details and usage instructions

This access-esm1.6 model will be deployed as:

  • dev_2024.12.0 as a Release (when merged).
  • pr43-3 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-esm1p6/pr43-3

where the binaries shall be on your $PATH.
This Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-esm1p6-pr43-3 environment.

🛠️ Using: spack 0.22, spack-packages 2024.12.0, spack-config 2025.01.1

Details

It will be deployed using:

  • access-nri/spack on branch 0.22
  • access-nri/spack-packages version 2024.12.0
  • access-nri/spack-config version 2025.01.1

If this is not what was expected, commit changes to config/versions.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev-config
5 participants