Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tabs #793

Merged
merged 9 commits into from
Sep 20, 2024
Merged

Improve tabs #793

merged 9 commits into from
Sep 20, 2024

Conversation

atteggiani
Copy link
Contributor

Fixes #792.

  • Changed tab functionality:
    • Tab labels buttons need to have an id attached
    • Content need to define the attribute 'tabcontentfor=...' specifying the ID of the button that reveal that content - Contents are styled based on their tags. This means, for example, that inline contents can be placed inside a tab content using the tag.
  • Updated README with new tab functionality
  • Updated 'docs/getting_started/are.md' with new tab functionality
  • Updated 'docs/getting_started/set_up_nci_account.md' with new tab functionality
  • Updated docs/models/configurations/access-om.md' with new tab functionality
  • Updated 'docs/models/model_components/ocean.md' with new tab functionality
  • Updated 'docs/models/model_components/sea-ice.md' with new tab functionality

@atteggiani atteggiani self-assigned this Sep 19, 2024
@atteggiani atteggiani requested a review from a team September 19, 2024 00:21
Copy link

github-actions bot commented Sep 19, 2024

PR preview
⚠️ There was an error in the pr-preview deployment. For more information, please check the Actions tab.
2024-09-20 11:31 AEST

@KAUR1984
Copy link
Contributor

Thanks for the changes @atteggiani ! Might need to update it with the development branch before merging.

- Tab labels buttons need to have an id attached
- Content need to define the attribute 'tabcontentfor=...' specifying the ID of the button that reveal that content.
- Contents are styled based on their tags. This means inline contents can be placed (for example using the <span> tag).

This changes make tabs more useful and easy to use.
…, for a content that should be displayed if any of the tabs correspondent to those IDs is active.
@atteggiani atteggiani merged commit 9165a84 into development Sep 20, 2024
1 of 3 checks passed
@atteggiani atteggiani deleted the davide/improve_tabs branch September 20, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve tab functionality and implementations
2 participants