Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 01deg jra55 iaf bgc #68

Merged
merged 13 commits into from
Apr 10, 2024

Conversation

minghangli-uni
Copy link
Collaborator

Update 01deg_jra55_iaf_bgc configuration. Related #48

@minghangli-uni
Copy link
Collaborator Author

@aidanheerdegen It fails at QA test on

AssertionError: Expect collate executable set to mppnccombine-fast.

But from the discussion in the #60, it appears that the decision was made not to add "-fast" for all configurations?

@aidanheerdegen
Copy link
Member

aidanheerdegen commented Apr 9, 2024

But from the discussion in the #60, it appears that the decision was made not to add "-fast" for all configurations?

Definitely required for all high res (0.25 and 0.1) models. Just the 1 degree it isn't necessary or even faster.

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just a couple more things to fix up.

config.yaml Outdated Show resolved Hide resolved
config.yaml Outdated Show resolved Hide resolved
@aidanheerdegen
Copy link
Member

aidanheerdegen commented Apr 9, 2024

The test is failing because the manifests/exe.yaml has not been updated with the changed yatm.exe. You will need to comment out the

manifest:
  reproduce:
    exe: true

part of the config.yaml (or set to false) and do payu setup to update the manifests. Make sure payu doesn't add an experiment_uuid in this step. If it does this, and makes commit then git revert it and remove the experiment_uuid.

And then set reproduce back to true.

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @minghangli-uni

@aidanheerdegen aidanheerdegen merged commit 953d6c5 into dev-01deg_jra55_iaf_bgc Apr 10, 2024
8 checks passed
@aidanheerdegen aidanheerdegen deleted the update-01deg_jra55_iaf_bgc branch April 10, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants