Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!test Comment Command #137

Merged
merged 3 commits into from
Oct 17, 2024
Merged

!test Comment Command #137

merged 3 commits into from
Oct 17, 2024

Conversation

CodeGat
Copy link
Contributor

@CodeGat CodeGat commented Oct 15, 2024

This PR introduces a PR comment-command of the form:

!test repro [commit]

which runs a repro test comparing the HEAD of the source (PR) branch against the last common ancestor of the target (merged-into) branch, and optionally commits the result to the PR that the comment was found in.

This allows repro checks to be run on any branch, rather than just being automatically run on dev-* -> release-* PRs.

Appropriate safeguards have been taken so that the comment command will only work for users who have write/admin permissions on the PR they are commenting on.

In this PR:

  • Add in job to handle !test comment commands

Requires ACCESS-NRI/model-config-tests#73
References #120

@CodeGat CodeGat added the CI Continuous integration infrastructure label Oct 15, 2024
@CodeGat CodeGat self-assigned this Oct 15, 2024
@CodeGat CodeGat marked this pull request as ready for review October 17, 2024 05:26
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EXCITING!

@CodeGat CodeGat merged commit a30ee61 into main Oct 17, 2024
@CodeGat CodeGat deleted the 120-!test-comment-command branch October 17, 2024 05:39
CodeGat added a commit that referenced this pull request Oct 18, 2024
CodeGat added a commit that referenced this pull request Oct 18, 2024
CodeGat added a commit that referenced this pull request Oct 18, 2024
CodeGat added a commit that referenced this pull request Oct 18, 2024
CodeGat added a commit that referenced this pull request Oct 18, 2024
* Migrated CI from #137 and #136

* Quoted "!test" job name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants