Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Common test-repro Functionality in generate-checksums.yml #77

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Merge Common test-repro Functionality in generate-checksums.yml #77

wants to merge 1 commit into from

Conversation

CodeGat
Copy link
Collaborator

@CodeGat CodeGat commented Oct 18, 2024

In this PR, we remove the generate-checksums job from generate-checksums.yml in favour of calling the perfectly good test-repro.yml workflow, removing further duplication from the workflows in the code.

Closes #72

@CodeGat CodeGat self-assigned this Oct 18, 2024
@CodeGat
Copy link
Collaborator Author

CodeGat commented Oct 18, 2024

Note, will have to check that we don't have to add an input to test-repro that disables the check run from a on.workflow_dispatch workflow...
We may have to add permissions.checks:write once #76 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@CodeGat CodeGat

Labels
priority:medium type:enhancement type:infra Dealing with CI/CD Pipelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge generate-checksums.yml into test-repro.yml
1 participant
@CodeGat