Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forest plot API and Tutorial changes #185

Merged
merged 20 commits into from
Sep 23, 2024
Merged

Conversation

Jacobluke-
Copy link
Collaborator

No description provided.

JAnns98 and others added 16 commits March 20, 2024 10:42
fixed some spelling mistakes
Discovered several typos, fixed
Many spelling and wording/layout changes. Still WIP
Edits to hopefully make the notebook functional again
Attempt #2 at reviving the notebook errors
Attempt #3 at fixing the notebook errors
Attempt #4 at fixing notebook errors
Attempt #5 at fixing notebook
…nns98-patch-1

# Conflicts:
#	nbs/tutorials/07-forest_plot.ipynb
…BEST-python into JAnns98-patch-1

# Conflicts:
#	nbs/tests/mpl_image_tests/baseline_images/test_01_gardner_altman_unpaired_meandiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_02_gardner_altman_unpaired_mediandiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_03_gardner_altman_unpaired_hedges_g.png
#	nbs/tests/mpl_image_tests/baseline_images/test_04_gardner_altman_paired_hedges_g.png
#	nbs/tests/mpl_image_tests/baseline_images/test_04_gardner_altman_paired_meandiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_05_cummings_two_group_unpaired_meandiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_06_cummings_two_group_paired_meandiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_07_cummings_multi_group_unpaired.png
#	nbs/tests/mpl_image_tests/baseline_images/test_08_cummings_multi_group_paired.png
#	nbs/tests/mpl_image_tests/baseline_images/test_09_cummings_shared_control.png
#	nbs/tests/mpl_image_tests/baseline_images/test_101_gardner_altman_unpaired_propdiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_103_cummings_two_group_unpaired_propdiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_105_cummings_multi_group_unpaired_propdiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_106_cummings_shared_control_propdiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_107_cummings_multi_groups_propdiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_109_gardner_altman_ylabel.png
#	nbs/tests/mpl_image_tests/baseline_images/test_10_cummings_multi_groups.png
#	nbs/tests/mpl_image_tests/baseline_images/test_110_change_fig_size.png
#	nbs/tests/mpl_image_tests/baseline_images/test_111_change_palette_b.png
#	nbs/tests/mpl_image_tests/baseline_images/test_112_change_palette_c.png
#	nbs/tests/mpl_image_tests/baseline_images/test_113_desat.png
#	nbs/tests/mpl_image_tests/baseline_images/test_114_change_ylims.png
#	nbs/tests/mpl_image_tests/baseline_images/test_115_invert_ylim.png
#	nbs/tests/mpl_image_tests/baseline_images/test_116_ticker_gardner_altman.png
#	nbs/tests/mpl_image_tests/baseline_images/test_117_err_color.png
#	nbs/tests/mpl_image_tests/baseline_images/test_118_cummings_two_group_unpaired_meandiff_bar_width.png
#	nbs/tests/mpl_image_tests/baseline_images/test_119_wide_df_nan.png
#	nbs/tests/mpl_image_tests/baseline_images/test_11_inset_plots.png
#	nbs/tests/mpl_image_tests/baseline_images/test_120_long_df_nan.png
#	nbs/tests/mpl_image_tests/baseline_images/test_121_cohens_h_gardner_altman.png
#	nbs/tests/mpl_image_tests/baseline_images/test_122_cohens_h_cummings.png
#	nbs/tests/mpl_image_tests/baseline_images/test_123_sankey_gardner_altman.png
#	nbs/tests/mpl_image_tests/baseline_images/test_124_sankey_cummings.png
#	nbs/tests/mpl_image_tests/baseline_images/test_125_sankey_2paired_groups.png
#	nbs/tests/mpl_image_tests/baseline_images/test_126_sankey_2sequential_groups.png
#	nbs/tests/mpl_image_tests/baseline_images/test_127_sankey_multi_group_paired.png
#	nbs/tests/mpl_image_tests/baseline_images/test_128_sankey_transparency.png
#	nbs/tests/mpl_image_tests/baseline_images/test_129_zero_to_zero.png
#	nbs/tests/mpl_image_tests/baseline_images/test_12_gardner_altman_ylabel.png
#	nbs/tests/mpl_image_tests/baseline_images/test_130_zero_to_one.png
#	nbs/tests/mpl_image_tests/baseline_images/test_131_one_to_zero.png
#	nbs/tests/mpl_image_tests/baseline_images/test_132_shared_control_sankey_off.png
#	nbs/tests/mpl_image_tests/baseline_images/test_133_shared_control_flow_off.png
#	nbs/tests/mpl_image_tests/baseline_images/test_134_separate_control_sankey_off.png
#	nbs/tests/mpl_image_tests/baseline_images/test_135_separate_control_flow_off.png
#	nbs/tests/mpl_image_tests/baseline_images/test_136_style_sheets.png
#	nbs/tests/mpl_image_tests/baseline_images/test_13_multi_2group_color.png
#	nbs/tests/mpl_image_tests/baseline_images/test_14_gardner_altman_paired_color.png
#	nbs/tests/mpl_image_tests/baseline_images/test_15_change_palette_a.png
#	nbs/tests/mpl_image_tests/baseline_images/test_16_change_palette_b.png
#	nbs/tests/mpl_image_tests/baseline_images/test_17_change_palette_c.png
#	nbs/tests/mpl_image_tests/baseline_images/test_18_desat.png
#	nbs/tests/mpl_image_tests/baseline_images/test_19_dot_sizes.png
#	nbs/tests/mpl_image_tests/baseline_images/test_201_forest_plot_no_colorpalette.png
#	nbs/tests/mpl_image_tests/baseline_images/test_202_forest_plot_with_colorpalette.png
#	nbs/tests/mpl_image_tests/baseline_images/test_203_horizontal_forest_plot_no_colorpalette.png
#	nbs/tests/mpl_image_tests/baseline_images/test_204_horizontal_forest_plot_with_colorpalette.png
#	nbs/tests/mpl_image_tests/baseline_images/test_205_forest_mini_meta_horizontal.png
#	nbs/tests/mpl_image_tests/baseline_images/test_206_forest_mini_meta.png
#	nbs/tests/mpl_image_tests/baseline_images/test_20_change_ylims.png
#	nbs/tests/mpl_image_tests/baseline_images/test_21_invert_ylim.png
#	nbs/tests/mpl_image_tests/baseline_images/test_22_ticker_gardner_altman.png
#	nbs/tests/mpl_image_tests/baseline_images/test_23_ticker_cumming.png
#	nbs/tests/mpl_image_tests/baseline_images/test_24_wide_df_nan.png
#	nbs/tests/mpl_image_tests/baseline_images/test_25_long_df_nan.png
#	nbs/tests/mpl_image_tests/baseline_images/test_26_slopegraph_kwargs.png
#	nbs/tests/mpl_image_tests/baseline_images/test_27_gardner_altman_reflines_kwargs.png
#	nbs/tests/mpl_image_tests/baseline_images/test_28_unpaired_cumming_reflines_kwargs.png
#	nbs/tests/mpl_image_tests/baseline_images/test_29_paired_cumming_slopegraph_reflines_kwargs.png
#	nbs/tests/mpl_image_tests/baseline_images/test_30_sequential_cumming_slopegraph.png
#	nbs/tests/mpl_image_tests/baseline_images/test_31_baseline_cumming_slopegraph.png
#	nbs/tests/mpl_image_tests/baseline_images/test_47_cummings_unpaired_delta_delta_meandiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_48_cummings_sequential_delta_delta_meandiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_49_cummings_baseline_delta_delta_meandiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_50_delta_plot_ylabel.png
#	nbs/tests/mpl_image_tests/baseline_images/test_51_delta_plot_change_palette_a.png
#	nbs/tests/mpl_image_tests/baseline_images/test_52_delta_specified.png
#	nbs/tests/mpl_image_tests/baseline_images/test_53_delta_change_ylims.png
#	nbs/tests/mpl_image_tests/baseline_images/test_54_delta_invert_ylim.png
#	nbs/tests/mpl_image_tests/baseline_images/test_55_delta_median_diff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_56_delta_cohens_d.png
#	nbs/tests/mpl_image_tests/baseline_images/test_57_delta_show_delta2.png
#	nbs/tests/mpl_image_tests/baseline_images/test_58_delta_axes_invert_ylim.png
#	nbs/tests/mpl_image_tests/baseline_images/test_59_delta_axes_invert_ylim_not_showing_delta2.png
#	nbs/tests/mpl_image_tests/baseline_images/test_60_cummings_unpaired_mini_meta_meandiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_61_cummings_sequential_mini_meta_meandiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_62_cummings_baseline_mini_meta_meandiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_63_mini_meta_plot_ylabel.png
#	nbs/tests/mpl_image_tests/baseline_images/test_64_mini_meta_plot_change_palette_a.png
#	nbs/tests/mpl_image_tests/baseline_images/test_65_mini_meta_dot_sizes.png
#	nbs/tests/mpl_image_tests/baseline_images/test_66_mini_meta_change_ylims.png
#	nbs/tests/mpl_image_tests/baseline_images/test_67_mini_meta_invert_ylim.png
#	nbs/tests/mpl_image_tests/baseline_images/test_68_mini_meta_median_diff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_69_mini_meta_cohens_d.png
#	nbs/tests/mpl_image_tests/baseline_images/test_70_mini_meta_not_show.png
#	nbs/tests/mpl_image_tests/baseline_images/test_71_unpaired_delta_g.png
#	nbs/tests/mpl_image_tests/baseline_images/test_72_sequential_delta_g.png
#	nbs/tests/mpl_image_tests/baseline_images/test_73_baseline_delta_g.png
#	nbs/tests/mpl_image_tests/baseline_images/test_99_style_sheets.png
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

# Conflicts:
#	dabest/_modidx.py
#	nbs/tests/mpl_image_tests/baseline_images/test_01_gardner_altman_unpaired_meandiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_02_gardner_altman_unpaired_mediandiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_03_gardner_altman_unpaired_hedges_g.png
#	nbs/tests/mpl_image_tests/baseline_images/test_04_gardner_altman_paired_hedges_g.png
#	nbs/tests/mpl_image_tests/baseline_images/test_04_gardner_altman_paired_meandiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_05_cummings_two_group_unpaired_meandiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_06_cummings_two_group_paired_meandiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_07_cummings_multi_group_unpaired.png
#	nbs/tests/mpl_image_tests/baseline_images/test_08_cummings_multi_group_paired.png
#	nbs/tests/mpl_image_tests/baseline_images/test_09_cummings_shared_control.png
#	nbs/tests/mpl_image_tests/baseline_images/test_101_gardner_altman_unpaired_propdiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_103_cummings_two_group_unpaired_propdiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_105_cummings_multi_group_unpaired_propdiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_106_cummings_shared_control_propdiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_107_cummings_multi_groups_propdiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_109_gardner_altman_ylabel.png
#	nbs/tests/mpl_image_tests/baseline_images/test_10_cummings_multi_groups.png
#	nbs/tests/mpl_image_tests/baseline_images/test_110_change_fig_size.png
#	nbs/tests/mpl_image_tests/baseline_images/test_111_change_palette_b.png
#	nbs/tests/mpl_image_tests/baseline_images/test_112_change_palette_c.png
#	nbs/tests/mpl_image_tests/baseline_images/test_113_desat.png
#	nbs/tests/mpl_image_tests/baseline_images/test_114_change_ylims.png
#	nbs/tests/mpl_image_tests/baseline_images/test_115_invert_ylim.png
#	nbs/tests/mpl_image_tests/baseline_images/test_116_ticker_gardner_altman.png
#	nbs/tests/mpl_image_tests/baseline_images/test_117_err_color.png
#	nbs/tests/mpl_image_tests/baseline_images/test_118_cummings_two_group_unpaired_meandiff_bar_width.png
#	nbs/tests/mpl_image_tests/baseline_images/test_119_wide_df_nan.png
#	nbs/tests/mpl_image_tests/baseline_images/test_11_inset_plots.png
#	nbs/tests/mpl_image_tests/baseline_images/test_120_long_df_nan.png
#	nbs/tests/mpl_image_tests/baseline_images/test_121_cohens_h_gardner_altman.png
#	nbs/tests/mpl_image_tests/baseline_images/test_122_cohens_h_cummings.png
#	nbs/tests/mpl_image_tests/baseline_images/test_123_sankey_gardner_altman.png
#	nbs/tests/mpl_image_tests/baseline_images/test_124_sankey_cummings.png
#	nbs/tests/mpl_image_tests/baseline_images/test_125_sankey_2paired_groups.png
#	nbs/tests/mpl_image_tests/baseline_images/test_126_sankey_2sequential_groups.png
#	nbs/tests/mpl_image_tests/baseline_images/test_127_sankey_multi_group_paired.png
#	nbs/tests/mpl_image_tests/baseline_images/test_128_sankey_transparency.png
#	nbs/tests/mpl_image_tests/baseline_images/test_129_zero_to_zero.png
#	nbs/tests/mpl_image_tests/baseline_images/test_12_gardner_altman_ylabel.png
#	nbs/tests/mpl_image_tests/baseline_images/test_130_zero_to_one.png
#	nbs/tests/mpl_image_tests/baseline_images/test_131_one_to_zero.png
#	nbs/tests/mpl_image_tests/baseline_images/test_132_shared_control_sankey_off.png
#	nbs/tests/mpl_image_tests/baseline_images/test_133_shared_control_flow_off.png
#	nbs/tests/mpl_image_tests/baseline_images/test_134_separate_control_sankey_off.png
#	nbs/tests/mpl_image_tests/baseline_images/test_135_separate_control_flow_off.png
#	nbs/tests/mpl_image_tests/baseline_images/test_136_style_sheets.png
#	nbs/tests/mpl_image_tests/baseline_images/test_13_multi_2group_color.png
#	nbs/tests/mpl_image_tests/baseline_images/test_14_gardner_altman_paired_color.png
#	nbs/tests/mpl_image_tests/baseline_images/test_15_change_palette_a.png
#	nbs/tests/mpl_image_tests/baseline_images/test_16_change_palette_b.png
#	nbs/tests/mpl_image_tests/baseline_images/test_17_change_palette_c.png
#	nbs/tests/mpl_image_tests/baseline_images/test_18_desat.png
#	nbs/tests/mpl_image_tests/baseline_images/test_19_dot_sizes.png
#	nbs/tests/mpl_image_tests/baseline_images/test_201_forest_plot_no_colorpalette.png
#	nbs/tests/mpl_image_tests/baseline_images/test_202_forest_plot_with_colorpalette.png
#	nbs/tests/mpl_image_tests/baseline_images/test_203_horizontal_forest_plot_no_colorpalette.png
#	nbs/tests/mpl_image_tests/baseline_images/test_204_horizontal_forest_plot_with_colorpalette.png
#	nbs/tests/mpl_image_tests/baseline_images/test_205_forest_mini_meta_horizontal.png
#	nbs/tests/mpl_image_tests/baseline_images/test_206_forest_mini_meta.png
#	nbs/tests/mpl_image_tests/baseline_images/test_20_change_ylims.png
#	nbs/tests/mpl_image_tests/baseline_images/test_21_invert_ylim.png
#	nbs/tests/mpl_image_tests/baseline_images/test_22_ticker_gardner_altman.png
#	nbs/tests/mpl_image_tests/baseline_images/test_23_ticker_cumming.png
#	nbs/tests/mpl_image_tests/baseline_images/test_24_wide_df_nan.png
#	nbs/tests/mpl_image_tests/baseline_images/test_25_long_df_nan.png
#	nbs/tests/mpl_image_tests/baseline_images/test_26_slopegraph_kwargs.png
#	nbs/tests/mpl_image_tests/baseline_images/test_27_gardner_altman_reflines_kwargs.png
#	nbs/tests/mpl_image_tests/baseline_images/test_28_unpaired_cumming_reflines_kwargs.png
#	nbs/tests/mpl_image_tests/baseline_images/test_29_paired_cumming_slopegraph_reflines_kwargs.png
#	nbs/tests/mpl_image_tests/baseline_images/test_30_sequential_cumming_slopegraph.png
#	nbs/tests/mpl_image_tests/baseline_images/test_31_baseline_cumming_slopegraph.png
#	nbs/tests/mpl_image_tests/baseline_images/test_47_cummings_unpaired_delta_delta_meandiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_48_cummings_sequential_delta_delta_meandiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_49_cummings_baseline_delta_delta_meandiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_50_delta_plot_ylabel.png
#	nbs/tests/mpl_image_tests/baseline_images/test_51_delta_plot_change_palette_a.png
#	nbs/tests/mpl_image_tests/baseline_images/test_52_delta_specified.png
#	nbs/tests/mpl_image_tests/baseline_images/test_53_delta_change_ylims.png
#	nbs/tests/mpl_image_tests/baseline_images/test_54_delta_invert_ylim.png
#	nbs/tests/mpl_image_tests/baseline_images/test_55_delta_median_diff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_56_delta_cohens_d.png
#	nbs/tests/mpl_image_tests/baseline_images/test_57_delta_show_delta2.png
#	nbs/tests/mpl_image_tests/baseline_images/test_58_delta_axes_invert_ylim.png
#	nbs/tests/mpl_image_tests/baseline_images/test_59_delta_axes_invert_ylim_not_showing_delta2.png
#	nbs/tests/mpl_image_tests/baseline_images/test_60_cummings_unpaired_mini_meta_meandiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_61_cummings_sequential_mini_meta_meandiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_62_cummings_baseline_mini_meta_meandiff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_63_mini_meta_plot_ylabel.png
#	nbs/tests/mpl_image_tests/baseline_images/test_64_mini_meta_plot_change_palette_a.png
#	nbs/tests/mpl_image_tests/baseline_images/test_65_mini_meta_dot_sizes.png
#	nbs/tests/mpl_image_tests/baseline_images/test_66_mini_meta_change_ylims.png
#	nbs/tests/mpl_image_tests/baseline_images/test_67_mini_meta_invert_ylim.png
#	nbs/tests/mpl_image_tests/baseline_images/test_68_mini_meta_median_diff.png
#	nbs/tests/mpl_image_tests/baseline_images/test_69_mini_meta_cohens_d.png
#	nbs/tests/mpl_image_tests/baseline_images/test_70_mini_meta_not_show.png
#	nbs/tests/mpl_image_tests/baseline_images/test_71_unpaired_delta_g.png
#	nbs/tests/mpl_image_tests/baseline_images/test_72_sequential_delta_g.png
#	nbs/tests/mpl_image_tests/baseline_images/test_73_baseline_delta_g.png
#	nbs/tests/mpl_image_tests/baseline_images/test_99_style_sheets.png
.cursorignore Outdated Show resolved Hide resolved
@Jacobluke- Jacobluke- merged commit d1c123f into vnbdev Sep 23, 2024
4 checks passed
@Jacobluke- Jacobluke- deleted the feat-forestplot-apiTut-changes branch September 23, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants