Feature/openapi #10
Feature/openapi #10
Conversation
* Adds ACCESS_TOKEN * Bypass sheepdog to load program-project * Idempotent document ids * Adds fhir_store in ES * Improve index already exists logging
* Fix: temp table in loop * adds click wrapper functions so that functions can be used in other envs --------- Co-authored-by: matthewpeterkort <[email protected]>
There was a problem hiding this comment.
Pytests pass. Fhir bundle functionality looks good.
Had a couple of questions/requests in the comments. The main one being adding FHIR individual resource submission to the openapi/code/tests.
Didn't know about the OperationOutcomeIssue, OperationOutcome, bundleEntryResponse and BundleEntry fhir.resources objects. Seems like the fhir.resources library is really built out.
| "identifier": [{"system": "https://example.org/my_id", "value": "test-foo"}], | ||
| } | ||
|
|
||
| VALID_REQUEST_BUNDLE = { |
There was a problem hiding this comment.
Not sure how much of the data that we're going to be getting will be in FHIR bundle format.
Would be very useful to add a more simple PUT for FHIR resource type X.
There was a problem hiding this comment.
Have created a grip RESTFUL endpoint that accepted
curl -X POST -H "Content-Type: applicationjson" -d '{"vertex": "../../aced-data/grip-aced-data/Observation.ndjson"}' http://localhost:8201/api/writer/test/bulk-load
style curl request that would bulk load a vertex file to grip. Adding this functionality in here would be very useful.
| - url: https://aced-idp.org/Bundle | ||
| description: ACED FHIR Bundle Implementation | ||
| paths: | ||
| /Bundle: |
There was a problem hiding this comment.
Would be very useful to add a fhir individual resource submission to the openapi too
bwalsh
force-pushed
the
feature/openapi
branch
2 times, most recently
from
0a0aea2 to
61ccbc8
Compare
* Adds ACCESS_TOKEN * Bypass sheepdog to load program-project * Idempotent document ids * Adds fhir_store in ES * Improve index already exists logging
* Fix: temp table in loop * adds click wrapper functions so that functions can be used in other envs --------- Co-authored-by: matthewpeterkort <[email protected]>
bwalsh
force-pushed
the
feature/openapi
branch
from
61ccbc8 to
ff9d975
Compare
Adds definition of submission service see #9