Assemble weights separately from the design matrix #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've merged main into this branch and made some small fixes - this now works with tutorials. If you are happy then can we merge and tag? |
|
Thanks - I fixed that same bug once, but it was on a plane and apparently I never pushed. At the same time, I updated the ACE1pack tests/tutorials to work with assemble returning A,Y instead of A,Y,W. But I can understand your point about that being a big change. Let's leave things as they are now. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @cortner, one option towards https://github.com/ACEsuit/ACE1pack.jl/issues/125 is to assemble the full weight vector in a separate step from the design matrix. I've started to sketch it out - before I do anything else, does this direction sound good for the short term? It wouldn't preclude anything else we've discussed over longer timescales.