Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSVD Postprocessing of ASP #83

Merged
merged 3 commits into from
Sep 9, 2024
Merged

TSVD Postprocessing of ASP #83

merged 3 commits into from
Sep 9, 2024

Conversation

cortner
Copy link
Member

@cortner cortner commented Sep 9, 2024

@tinatorabi -- all I did is put together an experimental postprocessing of the entire ASP path. It is not quite as fast as I had hoped, but it is ok-ish. Maybe a bit more profiling can make it better. If one were to store only every 10th iterate on the ASP path then I think the cost of ASP and TSVD postprocessing would be balanced. Maybe this is an option to introduce to the ASP solver?

I can't continue anymore tonight. Please feel free to push directly to this branch (you have write-access) to continue to integrate it with the ASP solver.

I suggest:

  • introduce another solver parameter tsvd = true/false (default false for now)
  • introduce another solver parameter nstore::Integer (default nstore = 100) to say how many ASP steps to save. You can sub-sample the full ASP path via somethime like every = len ÷ nstore and then [ path[1:every:end]; path[end]]

I hope this makes sense.

Also post here when you are done for the day so I know to pick this up again.

@tinatorabi
Copy link
Collaborator

I integrated tsvd with asp. I think this is all I need for the paper. :)

@cortner cortner merged commit b021f6a into main Sep 9, 2024
7 of 9 checks passed
@cortner cortner deleted the asp_svd branch September 9, 2024 19:49
@cortner cortner mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants