Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warm-start selection using Select #87

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Conversation

tinatorabi
Copy link
Collaborator

This PR adds a function called select to the asp framework. The user can call select(tracer, solver, A, y) to warm-start a new selection using a previously computed tracer.

@tinatorabi
Copy link
Collaborator Author

Do we need anything else added to this?

@cortner
Copy link
Member

cortner commented Sep 13, 2024

I'll review as soon as I'm free - later tonight.

Copy link
Member

@cortner cortner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this done. Can you change as I suggest, or if you disagree, explain why it should be as you wrote it?

src/asp.jl Show resolved Hide resolved
@cortner cortner changed the base branch from main to aspselect September 14, 2024 06:46
@cortner
Copy link
Member

cortner commented Sep 14, 2024

I'm merging this into a new branch, so I can quickly wrap this up. If I get stuck I'll ping you.

@cortner cortner merged commit 44418b6 into ACEsuit:aspselect Sep 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants