AtomsBase 0.5 Compat #301
Merged
AtomsBase 0.5 Compat #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An urgent bugfix has now been merged into this branch. I'll now see if I can get this to work. |
|
@Alexsp32 - the bugfixes from the last PR seem to also have resolved the tests for yours. This version now seems compatible with AtomsBase 0.5. If you are happy I'll go ahead, merge and register this. I did notice though that there are limitations on Lux and Zygote. Is that a potential problem for you? |
|
Sounds good to me, thanks for checking on this again! Lux and Zygote aren't causing any conflicts yet so I presume it's easiest to leave for now. |
|
now registered as 0.9.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #298.