Parse Firefox profiles.ini for friendly profile names #68
Conversation
|
To use Codex here, create a Codex account and connect to github. |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pub fn get_firefox_profiles() -> Result<Vec<ProfileDescriptor>, Box<dyn std::error::Error>> { | ||
| use std::path::PathBuf; | ||
| use ini::Ini; |
There was a problem hiding this comment.
The Firefox profile parsing code imports ini::Ini, but the new dependency was added under the name rust-ini in Cargo.toml. Because Cargo exposes the crate as rust_ini by default, the module ini does not exist and the project fails to compile. Rename the dependency to ini (or alias it) or change the import to rust_ini::Ini so the code builds.
Useful? React with 👍 / 👎.
|
Hey! I’ve made the changes to fix the rust-ini import issue. |
2 participants
This PR improves the get_firefox_profiles() function by adding support for parsing Firefox’s profiles.ini file to display readable profile names instead of raw folder names.
Key Updates
Benefits
Fixes: #49