New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wide & deep separation + extra calibration in TE #16

Open

umbnat92 wants to merge 1 commit into ACTCollaboration:master from umbnat92:master

umbnat92 commented Sep 16, 2021

No description provided.


          wide & deep separation

45bd306

Collaborator

xzackli commented Sep 17, 2021

Thanks for this PR, @umbnat92. I just have two minor concerns,

Could you add some unit tests for the deep and wide? Just a quick likelihood check for each is fine.
By default this code shouldn't print, or at least it should have the option of turning off printing. Otherwise some samplers will have output logs that consist of 10^6 of your debug statement. Maybe just add a debug_print option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet