Apply suggestions from code review

Co-authored-by: Mehdi Goli <[email protected]>
AD2605 · May 24, 2024 · 80b306c · 80b306c
1 parent 2773705
commit 80b306c
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 4 deletions.
diff --git a/include/cute/arch/mma_xe.hpp b/include/cute/arch/mma_xe.hpp
@@ -53,4 +53,4 @@ struct XE_1x16x16_BF16BF16F32F32_NN
     d = intel_sub_group_bf16_bf16_matrix_mad_k16(a, b, c);
   }
 };
-} //namespace cute
+} //namespace cute
diff --git a/include/cute/atom/copy_atom.hpp b/include/cute/atom/copy_atom.hpp
@@ -769,6 +769,8 @@ print_latex_copy(LayoutS const& S, ThrIDS const& TS,  // (m,n) -> (tid,vid)  and
 #include <cute/atom/copy_traits_sm90_tma.hpp>
 #endif
 
+#if defined(CUTLASS_ENABLE_SYCL)
 #include <cute/atom/copy_traits_xe.hpp>
+#endif
 
 ////////////////////////////////////////////////////////////////////////////////////////////////////
diff --git a/include/cute/atom/copy_traits_xe.hpp b/include/cute/atom/copy_traits_xe.hpp
@@ -60,4 +60,4 @@ namespace cute
         Traits traits{gtensor};
         return Copy_Atom<Traits, typename GEngine::value_type>{traits};
     }
-}
+}
diff --git a/include/cute/atom/mma_atom.hpp b/include/cute/atom/mma_atom.hpp
@@ -946,5 +946,7 @@ print_latex_mma(LayoutC const& C, ThrIDC const& TC,  // (m,n) -> (tid,vid)  and
 #include <cute/atom/mma_traits_sm80.hpp>
 #include <cute/atom/mma_traits_sm90.hpp>
 #include <cute/atom/mma_traits_sm90_gmma.hpp>
+#if defined(CUTLASS_ENABLE_SYCL)
 #include <cute/atom/mma_traits_xe.hpp>
+#endif
 ////////////////////////////////////////////////////////////////////////////////////////////////////
diff --git a/include/cute/atom/mma_traits_xe.hpp b/include/cute/atom/mma_traits_xe.hpp
@@ -21,4 +21,4 @@ struct MMA_Traits<XE_8x16x16_BF16BF16F32F32_NN>
   using BLayout = Layout<Shape<_16, _16>, Stride<_16, _1>>;
   using CLayout = Layout<Shape<_8, _16>, Stride<_8, _1>>;
 };
-}
+}
diff --git a/include/cute/util/sycl_vec.hpp b/include/cute/util/sycl_vec.hpp
@@ -14,4 +14,4 @@ using short8 = vector_t<short, 8>;
 using ushort8 = vector_t<ushort, 8>;
 using int2_ = vector_t<int, 2>; //conflicts with vector_types
 using int8 = vector_t<int, 8>;
-using uint8 = vector_t<uint, 8>;
+using uint8 = vector_t<uint, 8>;
-Original file line number
+Diff line change
@@ Expand Up / @@ -60,4 +60,4 @@ namespace cute @@
             Traits traits{gtensor};
             return Copy_Atom<Traits, typename GEngine::value_type>{traits};
         }
-    }
+    }