Update to be compatible with Python 3 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| build/lib.linux-x86_64-3.7/wex_utils.cpython-37m-x86_64-linux-gnu.so |
There was a problem hiding this comment.
I'm not sure if there should be a .so file included in the repo since this could cause compatibility issues.
| @@ -2,7 +2,8 @@ | |||
| import networkx as nx | |||
| import pandas as pd | |||
| import heapq | |||
| import cPickle as pickle | |||
| #KFW import cPickle as pickle | |||
There was a problem hiding this comment.
This could probably be better handled by:
try:
import cPickle as pickle
except ImportError:
import pickleI guess this depends on whether we want to maintain python 2/3 compatibility or if we're dropping python2 completely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing the tutorial
https://www.livecomsjournal.org/article/10607-a-suite-of-tutorials-for-the-westpa-rare-events-sampling-software-article-v1-0
under Matt's Python 3 WESTPA, I encountered some errors. I attempted to fix some of these messages. My changes should have a #KFW in front of the line. Can you also take a look at the provided WExplore_analysis.py in the tutorial? I'm getting a
ModuleNotFoundError: No module named 'westpa.binning'when executing it but it may be that my WESTPA environment is not correct?