-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs update #128
Docs update #128
Conversation
@berkatik You must remove all of the non-code files from this MR. You should set your DS STORE to be ignored globally e.g. https://stackoverflow.com/questions/7335420/global-git-ignore#7335487 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove junk files. Impossible to understand the changes without it.
@salotz I removed the .ds_store and similar files from the commit. Sphinx/src/_source has the files for compiling, should I get rid of them? |
.gitignore
Outdated
.DS_Store | ||
.buildinfo | ||
.git | ||
.nojekyll | ||
objects.inv | ||
.vscode/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project gitignore should only contain ignores relevant to the project itself so you shouldn't need to add the following:
.vscode/
.DS_Store
These should be ignored in your global gitignore configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, sorry. Updated the .gitignore accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.git
should not need to go into the .gitignore
either. Git knows to ignore itself.
What are the other things in this listing you added?
@berkatik You need to rebase your commits so that no commit has the DS_Store files btw. (If this was merging to main branch...) I was going to ask what you were trying to accomplish, but I see now that you are merging into the pages branch. You shouldn't need to manually merge into the documentation branch, that should be automatically committed to with the tooling. The old instructions are here: https://github.com/ADicksonLab/wepy/blob/master/info/dev_guide.org#building-documentation The relevant command to run is here if you want to do it manually: Lines 354 to 359 in 44dec1b
Overall you should make an MR with only the changes to the sources of the documentation. Then you just need to run the commands to build and deploy the docs to that branch. |
Ok, I'll look into the tooling. I meant to share the changes before publishing to pages. |
We can make this more automated as well by using Github Actions so that you only should need to commit the changes to the source files on |
No description provided.