Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs update #128

Closed
wants to merge 4 commits into from
Closed

Docs update #128

wants to merge 4 commits into from

Conversation

berkatik
Copy link
Collaborator

No description provided.

@salotz
Copy link
Collaborator

salotz commented Aug 30, 2024

@berkatik You must remove all of the non-code files from this MR. You should set your DS STORE to be ignored globally e.g. https://stackoverflow.com/questions/7335420/global-git-ignore#7335487

Copy link
Collaborator

@salotz salotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove junk files. Impossible to understand the changes without it.

@berkatik
Copy link
Collaborator Author

@salotz I removed the .ds_store and similar files from the commit. Sphinx/src/_source has the files for compiling, should I get rid of them?

.gitignore Outdated
Comment on lines 1 to 6
.DS_Store
.buildinfo
.git
.nojekyll
objects.inv
.vscode/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project gitignore should only contain ignores relevant to the project itself so you shouldn't need to add the following:

  • .vscode/
  • .DS_Store

These should be ignored in your global gitignore configuration.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, sorry. Updated the .gitignore accordingly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.git should not need to go into the .gitignore either. Git knows to ignore itself.

What are the other things in this listing you added?

@salotz
Copy link
Collaborator

salotz commented Sep 3, 2024

@berkatik You need to rebase your commits so that no commit has the DS_Store files btw. (If this was merging to main branch...)

I was going to ask what you were trying to accomplish, but I see now that you are merging into the pages branch.

You shouldn't need to manually merge into the documentation branch, that should be automatically committed to with the tooling. The old instructions are here: https://github.com/ADicksonLab/wepy/blob/master/info/dev_guide.org#building-documentation

The relevant command to run is here if you want to do it manually:

wepy/tasks/modules/py.py

Lines 354 to 359 in 44dec1b

def website_deploy(cx):
"""Deploy the documentation onto the internet."""
# use the ghp-import tool which handles the branch switching to
# `gh-pages` for you
cx.run("ghp-import --no-jekyll --push --force sphinx/_build/html")

Overall you should make an MR with only the changes to the sources of the documentation. Then you just need to run the commands to build and deploy the docs to that branch.

@berkatik
Copy link
Collaborator Author

berkatik commented Sep 3, 2024

Ok, I'll look into the tooling. I meant to share the changes before publishing to pages.

@alexrd
Copy link
Collaborator

alexrd commented Sep 3, 2024

Yes, I was also thinking that having a way of sharing the changes to the docs prior to publishing would be ideal. I see that we can just make changes to the org files in the master branch and make a PR for those. @berkatik will do that instead :)

Thanks for your help @salotz !

@alexrd alexrd closed this Sep 3, 2024
@salotz
Copy link
Collaborator

salotz commented Sep 3, 2024

We can make this more automated as well by using Github Actions so that you only should need to commit the changes to the source files on main and the the pipeline can publish them. E.g. #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants