feat(statutory,su): improve handling cancelled applications #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonVreling
changed the title
WikiRik
changed the title
WikiRik
requested changes
Jan 17, 2024
| @@ -260,6 +260,9 @@ export default { | |||
| canEditSelectedBody () { | |||
| return this.can.set_board_comment_and_participant_type.global | |||
| || this.can.set_board_comment_and_participant_type[this.selectedBody] | |||
| }, | |||
| nonCancelledApplications () { | |||
| return this.applications.filter(app => !app.cancelled) | |||
There was a problem hiding this comment.
Not sure yet why, but it seems that cancelled applications are not sent to the BoardView. Even if you click the button in the view table.
At first sight it looks fine in the listBoardView function so it's being set somewhere else in statutory. https://github.com/AEGEE/statutory/blob/43ab951729e9d3580ec40f58775c069062c1322f/lib/applications.js#L193-L195
| <span v-if="props.row.status === 'waiting_list'">Waiting list</span> | ||
| <span v-if="props.row.status === 'pending'">Pending</span> | ||
| <span v-if="props.row.cancelled"> | ||
| <span class="tag is-danger" v-if="props.row.cancelled"> |
There was a problem hiding this comment.
This looks strange for rejected applications. And it would be better if cancelled participants do not have a colored column (or colored grey)
|
@LeonVreling reminder that this one is still open |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.