Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Combine IFeatureActiveService & IFeatureDisableService to IFeatureMan…
…agementService
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| using Volo.Abp.DependencyInjection; | ||
|
|
||
| namespace AElf.Kernel.FeatureManagement.Core; | ||
|
|
||
| public interface IFeatureManagementService | ||
| { | ||
| Task<bool> IsFeatureActive(string featureName); | ||
| Task<bool> IsFeatureDisabledAsync(params string[] featureNames); | ||
| } | ||
|
|
||
| public class DefaultFeatureManagementService : IFeatureManagementService, ITransientDependency | ||
| { | ||
| public Task<bool> IsFeatureActive(string featureName) | ||
| { | ||
| return Task.FromResult(false); | ||
| } | ||
|
|
||
| public Task<bool> IsFeatureDisabledAsync(params string[] featureNames) | ||
| { | ||
| return Task.FromResult(false); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| using AElf.Kernel.Configuration; | ||
| using AElf.Kernel.FeatureManagement.Core; | ||
| using AElf.Modularity; | ||
| using Volo.Abp.Modularity; | ||
|
|
||
| namespace AElf.Kernel.FeatureManagement; | ||
|
|
||
| [DependsOn( | ||
| typeof(FeatureManagementCoreAElfModule), | ||
| typeof(ConfigurationAElfModule) | ||
| )] | ||
| public class FeatureManagementAElfModule : AElfModule | ||
| { | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| using System.Collections.Generic; | ||
|
|
||
| namespace AElf.Kernel.FeatureManagement; | ||
|
|
||
| public class FeatureManagementOptions | ||
| { | ||
| public List<string> DisableFeatureNameList { get; set; } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| using System.Linq; | ||
| using System.Threading.Tasks; | ||
| using AElf.Kernel.Blockchain.Application; | ||
| using AElf.Kernel.Configuration; | ||
| using AElf.Kernel.FeatureManagement.Core; | ||
| using Google.Protobuf; | ||
| using Google.Protobuf.WellKnownTypes; | ||
| using Volo.Abp.DependencyInjection; | ||
|
|
||
| namespace AElf.Kernel.FeatureManagement; | ||
|
|
||
| public class FeatureManagementService : IFeatureManagementService, ITransientDependency | ||
| { | ||
| private readonly IBlockchainService _blockchainService; | ||
| private readonly IConfigurationService _configurationService; | ||
| private readonly IDisabledFeatureListProvider _disabledFeatureListProvider; | ||
|
|
||
| public FeatureManagementService(IConfigurationService configurationService, IBlockchainService blockchainService, | ||
| IDisabledFeatureListProvider disabledFeatureListProvider) | ||
| { | ||
| _configurationService = configurationService; | ||
| _blockchainService = blockchainService; | ||
| _disabledFeatureListProvider = disabledFeatureListProvider; | ||
| } | ||
|
|
||
| public async Task<bool> IsFeatureActive(string featureName) | ||
| { | ||
| var featureConfigurationName = GetFeatureConfigurationName(featureName); | ||
| var chain = await _blockchainService.GetChainAsync(); | ||
| var activeHeightByteString = await _configurationService.GetConfigurationDataAsync(featureConfigurationName, | ||
| new ChainContext | ||
| { | ||
| BlockHeight = chain.BestChainHeight, | ||
| BlockHash = chain.BestChainHash | ||
| }); | ||
| var activeHeight = new Int64Value(); | ||
| activeHeight.MergeFrom(activeHeightByteString); | ||
| if (activeHeight.Value == 0) return false; | ||
|
|
||
| return chain.BestChainHeight >= activeHeight.Value; | ||
| } | ||
|
|
||
| private string GetFeatureConfigurationName(string featureName) | ||
| { | ||
| return $"{FeatureManagementConstants.FeatureConfigurationNamePrefix}{featureName}"; | ||
| } | ||
|
|
||
| public async Task<bool> IsFeatureDisabledAsync(params string[] featureNames) | ||
| { | ||
| var chain = await _blockchainService.GetChainAsync(); | ||
| if (chain == null || chain.BestChainHeight <= 1) | ||
| { | ||
| // Which means chain hasn't been created yet or only genesis block exists. | ||
| return false; | ||
| } | ||
|
|
||
| var nameList = await _disabledFeatureListProvider.GetDisabledFeatureListAsync(new BlockIndex | ||
| { | ||
| BlockHash = chain.BestChainHash, | ||
| BlockHeight = chain.BestChainHeight | ||
| }); | ||
| if (nameList.Length == 0) | ||
| { | ||
| return false; | ||
| } | ||
|
|
||
| var isDisabled = nameList.Select(n => n.Trim()).Intersect(featureNames).Any(); | ||
| return isDisabled; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.