Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-impl CryptoHelper's EncryptMessage & DecryptMessage #3564

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Conversation

eanzhao
Copy link
Contributor

@eanzhao eanzhao commented Jun 17, 2024

Via BouncyCastle

Related Issue: #3563

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 66.03774% with 18 lines in your changes missing coverage. Please review.

Project coverage is 90.62%. Comparing base (8dfa973) to head (2fb5acd).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3564      +/-   ##
==========================================
- Coverage   90.72%   90.62%   -0.11%     
==========================================
  Files         668      668              
  Lines       25941    25972      +31     
  Branches     2325     2327       +2     
==========================================
+ Hits        23535    23537       +2     
- Misses       2290     2320      +30     
+ Partials      116      115       -1     
Files Coverage Δ
src/AElf.Cryptography/CryptoHelper.cs 88.72% <100.00%> (+2.32%) ⬆️
...EDPoS/AEDPoSContract_GetConsensusBlockExtraData.cs 77.85% <0.00%> (-5.71%) ⬇️
...DPoS/AEDPoSContract_ProcessConsensusInformation.cs 80.70% <0.00%> (-3.75%) ⬇️
...s.Consensus.AEDPoS/AEDPoSContract_SecretSharing.cs 45.45% <41.17%> (-2.70%) ⬇️

... and 1 file with indirect coverage changes

@chopin-fan chopin-fan merged commit 6be7f5e into dev Jul 18, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants