-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/nextjs others ssr #145
base: refactor/nextjs-version
Are you sure you want to change the base?
Conversation
Pull request analysis by VIZIPI Below you will find who is the most qualified team member to review your code. Reviewers with knowledge related to these changes
Potential missing files from this Pull requestNo commonly committed files found with a 40% threashold Committed file ranks(click to expand)98.64% [src/pages/index.tsx] 88.42% [src/pages/tx/id/index.tsx] 94.10% [src/pages/block/id/index.tsx] 82.59% [src/page-components/Vote/Vote.js] 94.10% [src/components/PageHead/Header.tsx] 59.95% [src/page-components/Proposal/common/wallet.js] 59.95% [src/pages/proposal/createOrganizations/index.jsx] 25.74% [src/redux/features/proposal/common.ts] 87.21% [src/pages/address/address/index.tsx] 59.95% [src/pages/token/symbol/index.tsx] |
…-block-explorer into refactor/nextjs-others-ssr
'/proposal': 'Proposal', | ||
'/token': 'Token', | ||
myvote: 'My Vote', | ||
'/search-invalid': '', | ||
}; | ||
|
||
// I don't know why /new-socket can reach here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
const pathname = this.props.router.asPath; | ||
// I don't know why /new-socket can reach here | ||
const pathname = this.props.router.asPath.split('?')[0]; | ||
// if someone add path '/contract' to favourite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔???
@@ -12,19 +12,23 @@ import Link from 'next/link'; | |||
import { useDebounce } from 'react-use'; | |||
import CustomSkeleton from 'components/CustomSkeleton/CustomSkeleton'; | |||
import { withRouter } from 'next/router'; | |||
import { IProps, IRes, ITransactions, Itx } from './types'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Itx -> ITx or ITransaction
Refactor/nextjs sentry
except governance ssr