Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/nextjs others ssr #145

Open
wants to merge 114 commits into
base: refactor/nextjs-version
Choose a base branch
from

Conversation

AbigailDeng
Copy link
Contributor

except governance ssr

@vizipi
Copy link

vizipi bot commented Oct 19, 2022

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
19.62 % 轩辕焮痕 52 72
12.26 % minghao-98 45 45
2.72 % Abigail940404 1 10
2.18 % potter-sun 9 8
0.54 % AbigailDeng 1 2

Potential missing files from this Pull request

No commonly committed files found with a 40% threashold


Committed file ranks

(click to expand)
  • 98.64%[src/pages/index.tsx]
  • 88.42%[src/pages/tx/id/index.tsx]
  • 94.10%[src/pages/block/id/index.tsx]
  • 82.59%[src/page-components/Vote/Vote.js]
  • 94.10%[src/components/PageHead/Header.tsx]
  • 59.95%[src/page-components/Proposal/common/wallet.js]
  • 59.95%[src/pages/proposal/createOrganizations/index.jsx]
  • 25.74%[src/redux/features/proposal/common.ts]
  • 87.21%[src/pages/address/address/index.tsx]
  • 59.95%[src/pages/token/symbol/index.tsx]
  • @vizipi vizipi bot requested review from hzz780, minghao-98 and potter-sun October 19, 2022 02:54
    …-block-explorer into refactor/nextjs-others-ssr
    '/proposal': 'Proposal',
    '/token': 'Token',
    myvote: 'My Vote',
    '/search-invalid': '',
    };

    // I don't know why /new-socket can reach here
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @vizipi vizipi bot requested a review from hzz780 October 19, 2022 03:23
    const pathname = this.props.router.asPath;
    // I don't know why /new-socket can reach here
    const pathname = this.props.router.asPath.split('?')[0];
    // if someone add path '/contract' to favourite
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    🤔???

    @@ -12,19 +12,23 @@ import Link from 'next/link';
    import { useDebounce } from 'react-use';
    import CustomSkeleton from 'components/CustomSkeleton/CustomSkeleton';
    import { withRouter } from 'next/router';
    import { IProps, IRes, ITransactions, Itx } from './types';
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Itx -> ITx or ITransaction

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants