Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed command-line instruction for faucet and keep only web-f… #306

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

RutvikGhaskataEalf
Copy link
Collaborator

…aucet functionality instruction

Copy link

vizipi bot commented Oct 28, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
88.89% vasmohi 24 8
33.33% yongenaelf 12 3
22.22% AelfHarsh 10 2
22.22% zhifenglee-portkey 1 2
11.11% Rutvik 2 1

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
...docs/quick-start/developers/single-pool-staking-dapp/inde66.67%4 out of 6 times
docs/quick-start/developers/nft-dapp/index.md66.67%4 out of 6 times
docs/quick-start/developers/dao-dapp/index.md66.67%4 out of 6 times
docs/quick-start/developers/tic-tac-toe-dapp/index.md41.67%5 out of 12 times

Committed file ranks

(click to expand)
  • 90.61%[docs/quick-start/developers/_deploy_todo.md]
  • 93.06%[docs/_get-testnet-token.md]
  • 98.37%[docs/quick-start/developers/_deploy.md]
  • 57.14%[docs/quick-start/developers/_deploy_dao.md]
  • 57.14%[docs/quick-start/developers/_deploy_lottery.md]
  • 90.61%[docs/quick-start/developers/_deploy_single_pool_staking.md]
  • 88.16%[docs/quick-start/developers/_deploy_expense_tracker.md]
  • 82.72%[docs/tools/faucet/index.md]
  • 88.16%[docs/quick-start/developers/_deploy_tic_tac_toe.md]
  • @vasmohi vasmohi merged commit ae294b7 into develop Oct 29, 2024
    2 checks passed
    Copy link
    Collaborator

    @vasmohi vasmohi left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Reviewed and pushing to staging.

    yongenaelf added a commit that referenced this pull request Oct 30, 2024
    * feat: added allowance-dapp tutorial documentation (#305)
    
    * feat: Added documentation for allowance dapp (step 1-5)
    
    * feat/allowance-dapp
    
    * fix: Reviewed and fixed allowance dApp tutorial
    
    ---------
    
    Co-authored-by: vasmohi <[email protected]>
    
    * feat: removed command-line instruction for faucet and keep only web-faucet functionality instruction (#306)
    
    * Added Exception handled in remaining functions of NFT tutorial (#246)
    
    * Added Exception handled in remaining functions of NFT tutorial
    
    * Removed extra changes
    
    * feat: Removed mentions of zk-Rollups (#308)
    
    * Updated sequence
    
    * Fix: Updated roadmap image (#309)
    
    * feat: Removed mentions of zk-Rollups
    
    * fix: Updated roadmap image
    
    * fix: Updated aelf whitepaper v2.0 pdf (#310)
    
    * Feature: Updated dAppchain name (#312)
    
    * feat: Renamed sidechain to dAppchain
    
    * feat: Renamed mainchain AELF to aelf mainchain
    
    * fix: aelf mainchain
    
    ---------
    
    Co-authored-by: RutvikGhaskataEalf <[email protected]>
    Co-authored-by: yongenaelf <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants