Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Updated side chain to dAppchain #313

Merged
merged 9 commits into from
Oct 30, 2024
Merged

Feat: Updated side chain to dAppchain #313

merged 9 commits into from
Oct 30, 2024

Conversation

vasmohi
Copy link
Collaborator

@vasmohi vasmohi commented Oct 30, 2024

Updated side chain to dAppchain

RutvikGhaskataEalf and others added 8 commits October 30, 2024 01:12
* feat: Added documentation for allowance dapp (step 1-5)

* feat/allowance-dapp

* fix: Reviewed and fixed allowance dApp tutorial

---------

Co-authored-by: vasmohi <[email protected]>
* Added Exception handled in remaining functions of NFT tutorial

* Removed extra changes
* feat: Removed mentions of zk-Rollups

* fix: Updated roadmap image
* feat: Renamed sidechain to dAppchain

* feat: Renamed mainchain AELF to aelf mainchain
Copy link

vizipi bot commented Oct 30, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
64.86% yongenaelf 89 24
56.76% RutvikGhaskataEalf 37 21
13.51% b-aelf 26 5
13.51% AelfHarsh 16 5
13.51% zenan-aelf 12 5
10.81% zhifenglee-portkey 1 4

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
docs/quick-start/node-operators/_category_.json50.00%1 out of 2 times
docs/quick-start/developers/_category_.json50.00%1 out of 2 times
docs/quick-start/developers/tic-tac-toe-dapp/index.js50.00%1 out of 2 times

Committed file ranks

(click to expand)
  • 97.28%[...docs/quick-start/developers/single-pool-staking-dapp/inde]
  • 69.66%[...docs/quick-start/node-operators/set-up-a-node-on-mainnet/]
  • 92.52%[docs/quick-start/developers/_deploy_single_pool_staking.md]
  • 82.04%[docs/about-aelf/partnerships-and-ecosystem/index.md]
  • 69.66%[docs/about-aelf/wallet/index.md]
  • 69.66%[docs/quick-start/developers/_deploy_lottery.md]
  • 55.92%[docs/quick-start/node-operators/apply-to-be-a-bp/index.md]
  • 97.14%[docs/resources/whitepaper-2/executive-summary/index.md]
  • 55.92%[docs/quick-start/developers/_deploy_allowance_contract.md]
  • 55.92%[...docs/quick-start/node-operators/set-up-a-node-on-testnet/]
  • @yongenaelf yongenaelf merged commit 0304b0c into main Oct 30, 2024
    2 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants