Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add omitTelegramScript to omit tgscript on demand, and replace … #146

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

aelf-lxy
Copy link
Collaborator

@aelf-lxy aelf-lxy commented Sep 2, 2024

add omitTelegramScript to omit tgscript on demand, and replace require() with import() for vconsole, close #147

Copy link

vizipi bot commented Sep 2, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
6.67% AbigailDeng 8 1
6.67% curryZhaoAelf 1 1

Potential missing files from this Pull request

No commonly committed files found with a 40% threashold


Committed file ranks

(click to expand)
  • 86.79%[packages/bridge/src/index.ts]
  • 95.34%[packages/bridge/package.json]
  • 94.04%[packages/base/package.json]
  • 97.15%[packages/utils/package.json]
  • 89.12%[packages/react/src/index.tsx]
  • 90.41%[packages/starter/src/Demo/demo.tsx]
  • 95.08%[packages/wallets/portkey-aa/package.json]
  • 94.04%[packages/react/package.json]
  • 95.34%[packages/wallets/portkey-discover/package.json]
  • 88.08%[.github/workflows/test-badge.yml]
  • Copy link

    codecov bot commented Sep 2, 2024

    Codecov Report

    All modified and coverable lines are covered by tests ✅

    Project coverage is 89.76%. Comparing base (74a7f5a) to head (c56f146).
    Report is 3 commits behind head on master.

    Additional details and impacted files

    Impacted file tree graph

    @@           Coverage Diff           @@
    ##           master     #146   +/-   ##
    =======================================
      Coverage   89.76%   89.76%           
    =======================================
      Files          21       21           
      Lines         215      215           
      Branches       70       70           
    =======================================
      Hits          193      193           
      Misses          8        8           
      Partials       14       14           
    Flag Coverage Δ
    unittests 89.76% <ø> (ø)

    Flags with carried forward coverage won't be shown. Click here to find out more.

    @aelf-lxy aelf-lxy merged commit d61d809 into master Sep 2, 2024
    8 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    Add configuration for dynamic loading of telegram's scripts
    1 participant