Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 transformArrayToMap fieldsArray may undefined #129

Conversation

lhoopox
Copy link
Contributor

@lhoopox lhoopox commented Sep 19, 2023

Parsing can be problematic when the contract result contains an array of enumerated types

@vizipi
Copy link

vizipi bot commented Sep 19, 2023

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00 % AbigailDeng 23 7
57.14 % potter-sun 5 4

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
test/unit/chain/chainMethod.test.js50.00 %1 out of 2 times
package.json50.00 %1 out of 2 times
src/util/utils.js50.00 %1 out of 2 times
test/unit/chain/index.test.js50.00 %1 out of 2 times
test/unit/util/merkleTree.test.js50.00 %1 out of 2 times
test/unit/util/bloom.test.js50.00 %1 out of 2 times
test/unit/contract/contractMethod.test.js50.00 %1 out of 2 times
types/contract/contractMethod.d.ts50.00 %1 out of 2 times
test/unit/contract/index.test.js50.00 %1 out of 2 times
README.md50.00 %1 out of 2 times

Committed file ranks

(click to expand)
  • 97.64%[dist/aelf.umd.js]
  • 66.93%[src/util/transform.js]
  • 92.52%[test/unit/util/transform.test.js]
  • 97.64%[dist/aelf.cjs.js]
  • 80.71%[test/unit/util/token.proto.json]
  • 96.46%[dist/aelf.cjs.js.map]
  • 96.46%[dist/aelf.umd.js.map]
  • @vizipi vizipi bot requested review from AbigailDeng and potter-sun September 19, 2023 02:43
    @AbigailDeng AbigailDeng merged commit aa511e5 into AElfProject:feature/test-chain-util-workflow Sep 19, 2023
    1 of 2 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants