Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add verify #136

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

AbigailDeng
Copy link
Collaborator

No description provided.

Copy link

Total coverage

Lines Branches Functions Statements
99.42% (+0.01%) 98.85% (+0.00%) 99.03% (+0.01%) 99.45% (+0.01%)

Detailed report

click to open the diff coverage report
File Lines Branches Functions Statements
/home/runner/work/aelf-web3.js/aelf-web3.js/src/index.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
/home/runner/work/aelf-web3.js/aelf-web3.js/src/chain/chainMethod.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
/home/runner/work/aelf-web3.js/aelf-web3.js/src/chain/index.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
/home/runner/work/aelf-web3.js/aelf-web3.js/src/contract/contractMethod.js 99.15% (+99.15%) 97.22% (+97.22%) 100.00% (+100.00%) 99.15% (+99.15%)
/home/runner/work/aelf-web3.js/aelf-web3.js/src/contract/index.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
/home/runner/work/aelf-web3.js/aelf-web3.js/src/util/bloom.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
/home/runner/work/aelf-web3.js/aelf-web3.js/src/util/errors.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
/home/runner/work/aelf-web3.js/aelf-web3.js/src/util/formatters.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
/home/runner/work/aelf-web3.js/aelf-web3.js/src/util/httpProvider.js 96.33% (+96.33%) 93.54% (+93.54%) 92.00% (+92.00%) 96.42% (+96.42%)
/home/runner/work/aelf-web3.js/aelf-web3.js/src/util/keccak.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
/home/runner/work/aelf-web3.js/aelf-web3.js/src/util/keyStore.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
/home/runner/work/aelf-web3.js/aelf-web3.js/src/util/merkleTree.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
/home/runner/work/aelf-web3.js/aelf-web3.js/src/util/proto.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
/home/runner/work/aelf-web3.js/aelf-web3.js/src/util/requestManage.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
/home/runner/work/aelf-web3.js/aelf-web3.js/src/util/settings.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
/home/runner/work/aelf-web3.js/aelf-web3.js/src/util/sha256.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
/home/runner/work/aelf-web3.js/aelf-web3.js/src/util/transform.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
/home/runner/work/aelf-web3.js/aelf-web3.js/src/util/utils.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
/home/runner/work/aelf-web3.js/aelf-web3.js/src/wallet/index.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)

Copy link

vizipi bot commented Dec 29, 2023

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
60.00% potter-sun 5 3
20.00% lhoopox 1 1

Potential missing files from this Pull request

No commonly committed files found with a 40% threashold


Committed file ranks

(click to expand)
  • 61.15%[test/unit/wallet/index.test.js]
  • 85.38%[src/wallet/index.js]
  • 94.23%[README.md]
  • 99.62%[package.json]
  • 99.23%[yarn.lock]
  • @vizipi vizipi bot requested review from potter-sun and lhoopox December 29, 2023 02:27
    Copy link
    Contributor

    @potter-sun potter-sun left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @@ -90,4 +90,15 @@ describe('test wallet', () => {
    const _getWallet = Wallet.__GetDependency__('_getWallet');
    expect(() => _getWallet()).toThrow('not a valid method');
    });

    test('test verify', () => {
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Sign and verify can use the same privatekey, pubkey and msg.

    @hzz780 hzz780 merged commit 8f39fb2 into feature/test-chain-util Jan 3, 2024
    2 checks passed
    @delete-merged-branch delete-merged-branch bot deleted the feature/test-chain-util-verify branch January 3, 2024 02:42
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants