Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add address length check #154

Merged
merged 2 commits into from
May 22, 2024

Conversation

AbigailDeng
Copy link
Collaborator

No description provided.

Copy link

vizipi bot commented May 22, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
33.33% lhoopox 1 1

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
package.json50.00%1 out of 2 times
yarn.lock50.00%1 out of 2 times
src/contract/index.js50.00%1 out of 2 times
src/util/proto.js50.00%1 out of 2 times
test/unit/util/proto.test.js50.00%1 out of 2 times
test/unit/wallet/index.test.js50.00%1 out of 2 times
dist/aelf.umd.js50.00%1 out of 2 times
dist/aelf.umd.js.map50.00%1 out of 2 times
dist/aelf.cjs.js50.00%1 out of 2 times
test/unit/contract/index.test.js50.00%1 out of 2 times

Committed file ranks

(click to expand)
  • 71.01%[test/unit/util/formatter.test.js]
  • 0.00%[src/util/formatters.js]
  • 97.10%[README.md]
  • @vizipi vizipi bot requested a review from lhoopox May 22, 2024 11:36
    Copy link

    🔴 Total coverage is lower than the default branch

    Lines Branches Functions Statements
    99.32% (-0.09%) 98.64% (-0.21%) 99.05% (+0.03%) 99.35% (-0.09%)

    Detailed report

    click to open the diff coverage report
    File Lines Branches Functions Statements
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/index.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/chain/chainMethod.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/chain/index.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/contract/contractMethod.js 99.15% (+99.15%) 97.22% (+97.22%) 100.00% (+100.00%) 99.15% (+99.15%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/contract/index.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/bloom.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/errors.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/formatters.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/httpProvider.js 96.33% (+96.33%) 93.54% (+93.54%) 92.00% (+92.00%) 96.42% (+96.42%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/keccak.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/keyStore.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/merkleTree.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/proto.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/requestManage.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/settings.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/sha256.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/transform.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/utils.js 99.10% (+99.10%) 98.21% (+98.21%) 100.00% (+100.00%) 99.15% (+99.15%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/wallet/index.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)

    @hzz780 hzz780 merged commit 68d67e3 into feature/test-chain-util May 22, 2024
    1 of 2 checks passed
    @delete-merged-branch delete-merged-branch bot deleted the feature/test-chain-util-addressLength branch May 22, 2024 12:07
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants