Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/test chain merge master #166

Merged
merged 62 commits into from
Jun 24, 2024

Conversation

AbigailDeng
Copy link
Collaborator

No description provided.

AbigailDeng and others added 30 commits October 23, 2023 09:37
feat: verify pubKey deprecatedParam
add seedWithBuffer & change prettierrc
Copy link

vizipi bot commented Jun 24, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
20.41% potter-sun 14 20
14.29% 轩辕焮痕 11 14
8.16% lhoopox 5 8
4.08% Alef-hz 7 4

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
reporter/jest-junit.xml50.00%1 out of 2 times
.github/workflows/coverage.yml50.00%1 out of 2 times
test/unit/util/httpProvider.test.js50.00%1 out of 2 times
.vscode/settings.json50.00%1 out of 2 times
base-summary.json50.00%1 out of 2 times
src/util/keccak/keccak.js50.00%1 out of 2 times
src/util/keccak/api.js50.00%1 out of 2 times
src/util/keccak/index.js50.00%1 out of 2 times

Committed file ranks

(click to expand)
  • 88.61%[types/util/requestManage.d.ts]
  • 66.90%[build/webpack.browser.js]
  • 78.65%[test/unit/util/hash.test.js]
  • 66.90%[build/webpack.analyze.js]
  • 52.31%[test/unit/util/settings.test.js]
  • 88.61%[jest.node.config.js]
  • 52.31%[proto/virtual_transaction.proto.d.ts]
  • 52.31%[proto/core.proto]
  • 91.46%[types/util/proto.d.ts]
  • 88.61%[test/unit/util/utils.test.js]
  • Copy link

    🔴 Total coverage is lower than the default branch

    Lines Branches Functions Statements
    97.23% (-2.18%) 94.86% (-3.99%) 99.07% (+0.05%) 97.35% (-2.09%)

    Detailed report

    click to open the diff coverage report
    File Lines Branches Functions Statements
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/index.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/chain/chainMethod.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/chain/index.js 98.36% (+98.36%) 96.42% (+96.42%) 100.00% (+100.00%) 98.41% (+98.41%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/contract/contractMethod.js 88.35% (+88.35%) 77.27% (+77.27%) 100.00% (+100.00%) 88.66% (+88.66%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/contract/index.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/bloom.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/errors.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/formatters.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/httpProvider.js 93.96% (+93.96%) 91.04% (+91.04%) 92.00% (+92.00%) 94.06% (+94.06%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/keccak.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/keyStore.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/merkleTree.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/proto.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/requestManage.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/settings.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/sha256.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/transform.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/utils.js 99.16% (+99.16%) 98.21% (+98.21%) 100.00% (+100.00%) 99.20% (+99.20%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/wallet/index.js 100.00% (+100.00%) 90.90% (+90.90%) 100.00% (+100.00%) 100.00% (+100.00%)

    @hzz780 hzz780 merged commit a195d31 into feature/test-chain-util Jun 24, 2024
    1 of 2 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants