Restart from phdf outputs #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…restarting from .phdf files.
Previously, B_CT::UtoP on e.g. IndexDomain::inner_x1 would only update ghost cell centers. But changing the flux on the domain face calls for updating the first interior row too, since it's involved in averaging. Also patches up initializing/normalizing B in the presence of boundaries
Update first interior cells on B_CT::UtoP and fix B for tilts >45 degrees
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parthenon outputs dumps and restarts in basically the same format, so they can substitute for one another in a pinch. However, dumps generally lack face-centered or conserved magnetic fields, so they must be interpolated/multiplied appropriately, and in the case of face-centered fields must then be cleaned.
Luckily, we do all that stuff for
iharm3dformat restarts anyway, so I just re-use that code, and mark the cell-centeredprims.BasRestartso that it gets read, instead of justcons.fBwhich won't exist. The whole thing ends up pretty clean.Using this requires patching out Parthenon's type check,
src/outputs/restart.hppL125. If I'm not lazy I'll add that patch to the patchset before I merge this.Restarting from phdfs is already documented on the wiki: https://github.com/AFD-Illinois/kharma/wiki/Running-KHARMA#restarting-simulations.