Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening since last branch target was deleted.
Andrew Chael just published a GR Force-free E&M/Hybrid GRMHD+GRFFE scheme (https://arxiv.org/abs/2404.01471) which is also implemented in KORAL (https://github.com/achael/koral_lite).
It was too nice a scheme not to just have a go at implementing it in KHARMA (read: "shamelessly copying it from koral and changing variable names"), so here's a draft. This version is still buggy, and not feature-complete compared to KORAL's implementation, but the basics are there. Mostly I'm surprised the variable and package infra accommodates it so cleanly. Maybe finding the bugs will be hell or something, but at this point I'm pleasantly surprised.
Notably:
A bunch left to do here, and without pressing need I may not get back to it for a while. But it's here when someone wants it.