Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix windows thread local by refactoring the
thread_local!
into anos_thread_local::ThreadLocal
and embedding it in theAsanRuntime
type.This fix is necessary because static thread local storage appears to be broken on windows. The TEB is supposed to have a
ThreadLocalStoragePointer
, but it appears to be uninitialized even though thread_local variables were declared in the main executable, leading to a null deref.The os-thread-local crate uses a dynamic thread local storage api, and thus works.