feature: Ensure img_path is of type Path #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ns-rse
requested review from
MaxGamill-Sheffield,
SylviaWhittle and
llwiggins
Closes #106 Ensures that if fileversion >= 0.2 is being loaded that the `data["img_path"]` variable is of type `Path`. Adds to the test suite a 0.2 sample file to check this (and expands on the keys of the dictionary).
ns-rse
force-pushed
the
ns-rse/106-img_path
branch
from
c49f0a6 to
0135ec9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
==========================================
+ Coverage 65.87% 72.10% +6.22%
==========================================
Files 3 8 +5
Lines 337 595 +258
==========================================
+ Hits 222 429 +207
- Misses 115 166 +51 ☔ View full report in Codecov by Sentry. |
SylviaWhittle
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #106
Ensures that if fileversion >= 0.2 is being loaded that the
data["img_path"]variable is of typePath.Adds to the test suite a 0.2 sample file to check this (and expands on the keys of the dictionary).