-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file format STP #113
Add file format STP #113
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
==========================================
+ Coverage 65.87% 74.88% +9.01%
==========================================
Files 3 9 +6
Lines 337 661 +324
==========================================
+ Hits 222 495 +273
- Misses 115 166 +51 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relatively quick scan through as its after hours. Some minor comments on how we could perhaps keep things shorter without making it harder to understand. Possibly an extraneous notebook has crept in.
Don't think there is a huge need to abstract the header reading out to its own function unless you really wanted to.
Challenging thing is having example files that fail the tests. Mocking might be of use here but I appreciate its a fair amount of work and your busy.
Co-authored-by: Neil Shephard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not on the ball, sorry for the delay 👍
Closes #77
Adds
.stp
support.@ns-rse In my haste I've kept everything in one function. Should I split the header reading code out into its own function? I'm of two minds about it at the moment.
Also please do point out if I've omitted documentation somewhere.
I:
stp.py
test_stp.py
example_01.ipynb