Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encoder option for 9.99 volt asd files #50

Merged
merged 8 commits into from
May 29, 2024

Conversation

SylviaWhittle
Copy link
Collaborator

@SylviaWhittle SylviaWhittle commented May 11, 2024

Closes #42

This PR adds an option for allowing the 0x00000003 analogue-digital range corresponding to 9.99 Volts.

@SylviaWhittle SylviaWhittle marked this pull request as ready for review May 29, 2024 09:19
Copy link
Collaborator

@llwiggins llwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of the 0x00000003 analogue-digital mapping has successfully resolved the errors we were facing when reading in a particular set of asd images and so I would be happy for this PR to be merged. This code also provides a good format to use for adding new analogue-digital mappings if we need to in the future!

@SylviaWhittle SylviaWhittle merged commit 58309b6 into main May 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] : ASD - Add support for 9.99 volt images
2 participants